+1 for fixing #34 and related

[RA]

I found a bunch of old posts and a number of tickets on this issue.
FND, you are not alone! I want the wiki source to be readable too!
Without the penalty of lotsa blank space. Please, please fix it
already.


--R

[FND]

Context:
http://trac.tiddlywiki.org/ticket/34

> I found a bunch of old posts and a number of tickets on this issue.

Frankly, there's not much of a chance that this will be fixed any time
soon, mostly because it would break backwards compatibility.

However, this might be of interest:
http://groups.google.com/group/TiddlyWiki/t/372693e8296f5fe
http://tinyurl.com/6erqyt
(http://svn.tiddlywiki.org/Trunk/contributors/FND/formatters/ParagraphFormatter.js)

-- F.

[RA]

> However, this might be of interest:
> http://groups.google.com/group/TiddlyWiki/t/372693e8296f5fe
> http://tinyurl.com/6erqyt

> (http://svn.tiddlywiki.org/Trunk/contributors/FND/formatters/Paragraph...)

The plugin doesn't do anything for me for some reason...

[FND]

> The plugin doesn't do anything for me for some reason...

It works for me in an empty 2.5.0 document. Can you provide a test case*?

-- F.

* cf. http://www.tiddlywiki.org/wiki/Troubleshooting

[RA]

Sorry, it is working. Just not what I expected. Not even sure what I
expected. Could you explain what exactly it does? One line break is
swallowed but two line breaks remain as two line breaks? If so, then
what about three or four of them? In an odd number of line breaks the
last one is ignored?

-- R

[RA]

Another question if I may:

(function(formatters) {...})(config.formatters);

What does a construct like this give you, besides being another way to
say

var formatters = config.formatters;
...


--R

[FND]

> Sorry, it is working. Just not what I expected.

It was sort of a quick hack, more a proof of concept than anything.
Feel free to improve it; I'd happily accept useful changes.

> (function(formatters) {...})(config.formatters);
> What does a construct like this give you

Apart from the aliasing*, that closure also gives me a local scope,
preventing pollution of the global namespace.

N.B.:
Strictly development-related issues should be discussed on the dev group:
http://groups.google.com/group/TiddlyWikiDev/

-- F.

* http://tiddlywiki.org/wiki/Dev:Best_Practices#Creating_Aliases

[RA]

> It was sort of a quick hack, more a proof of concept than anything.

Understood. Still, could you confirm that the following is an accurate
and full description of it's functionality?

In an odd number of line breaks the last one is ignored.

[FND]

> In an odd number of line breaks the last one is ignored.

Well, not exactly.
Essentially, single line breaks are ignored, double line breaks create a
paragraph (though only visually; instead of the P element, BR elements
are used).

-- F.

[Eric Shulman]

> paragraph (though only visually; instead of the P element, BR elements
> are used).

Note: as I recall, the initial intent for ticket #34 was to find a way
to implement true <p>...</p> paragraph blocks, so that paragraph-level
custom CSS styles might be applied.

-e

[FND]

> as I recall, the initial intent for ticket #34 was to find a way
> to implement true <p>...</p> paragraph blocks, so that paragraph-level
> custom CSS styles might be applied.

Absolutely, yes.
However, that turned out to be tricky to implement for this plugin. (I
would of course welcome any suggestions on how it could be fixed.)

-- F.