On Jun 19, 2012, at 9:44 PM, shamy wrote:
> Isn't better to add supportsAVCaptureSessionPreset check for AVCaptureSessionPresetiFrame960x540 in all cases and switch to AVCaptureSessionPresetiFrame960x540 if it is supported by the device than doing it only for the retina iPad?
I didn't want to commit a change like that without testing, testing that I didn't have time to do.
There is a chance this would lower performance in some cases since a larger image requires more CPU to process.
There are also sometimes downsides to higher resolutions with zxing. For example, a full res image taken from an LCD will often not decode because at that resolution, the individual LCD pixels are resolvable and the zxing algorithms are not designed for that; a lower resolution gives you low pass filtering for free. The issue is less with lower res images but we haven't done much testing/experimenting.
So we can make the change, but it'd be best to see first if there are really are cases it helps and make sure it doesn't hurt others.