The end of E4X

144 views
Skip to first unread message

Simon Kornblith

unread,
Jul 1, 2012, 11:21:26 AM7/1/12
to zotero-dev
According to
http://groups.google.com/group/mozilla.dev.tech.js-engine/browse_thread/thread/c9843230270c7fed/56524e78c6075973?show_docid=56524e78c6075973,
E4X will be disabled by default for content in Firefox 16, for chrome
in Firefox 17, and will disappear entirely in Firefox 18. This means
that any translators that use E4X will stop working at that point.

Luckily, I don't think there are too many of these. A simple grep
shows:

Aluka.js
BioInfoBank.js
CTX.js
DTIC.js
Digital Medievalist.js
dLibra.js
Factiva.js
Internet Archive.js
MODS.js
Pleade.js
Protein Data Bank.js

I think the most important and complex of these is MODS, and I'll put
some time into getting it switched over. Depending on how disabling
E4X affects sandboxed code, which isn't really chrome or content, the
other translators here will cease to work either with the release of
Firefox 16 on October 9, 2012 or with the release of Firefox 17 on
November 20, 2012. It goes without saying that E4X should not be used
for new translators.

Simon

Simon Kornblith

unread,
Jul 4, 2012, 8:44:08 PM7/4/12
to zotero-dev
TEI should also be on this list. I didn't notice it at first because
it doesn't call new XML().

Simon

On Jul 1, 11:21 am, Simon Kornblith <si...@simonster.com> wrote:
> According tohttp://groups.google.com/group/mozilla.dev.tech.js-engine/browse_thre...,

Frank Bennett

unread,
Oct 18, 2012, 11:11:25 PM10/18/12
to zoter...@googlegroups.com

Simon,

I have some teamwork coming up next week for MLZ, to build a multilingual version of the MODS translator. Have you been able to make any progress on converting it from E4X to DOM? If not, we'll start our work at this end with that bit.

Frank

 

adamsmith

unread,
Oct 19, 2012, 12:34:37 AM10/19/12
to zoter...@googlegroups.com

Frank Bennett

unread,
Oct 19, 2012, 12:50:28 AM10/19/12
to zoter...@googlegroups.com
On Friday, October 19, 2012 1:34:37 PM UTC+9, adamsmith wrote:
Simon actually had a MODS DOM translator up:
https://github.com/zotero/translators/commit/95f76e03a77cbfd1427dfbb34e900abb19f3ce91
but reverted this due to prpoblems with FF 14:
https://github.com/zotero/translators/commit/ee54267170da6228d1839ac3555a8cb27c2dffb8


Sweet, thanks! We'll look at implementing multilingual against one version, then porting to the other.

Frank

 

Frank Bennett

unread,
Nov 22, 2012, 6:30:38 AM11/22/12
to zoter...@googlegroups.com
On Friday, October 19, 2012 1:50:28 PM UTC+9, Frank Bennett wrote:
On Friday, October 19, 2012 1:34:37 PM UTC+9, adamsmith wrote:
Simon actually had a MODS DOM translator up:
https://github.com/zotero/translators/commit/95f76e03a77cbfd1427dfbb34e900abb19f3ce91
but reverted this due to prpoblems with FF 14:
https://github.com/zotero/translators/commit/ee54267170da6228d1839ac3555a8cb27c2dffb8


Sweet, thanks! We'll look at implementing multilingual against one version, then porting to the other.

Frank

We have the multilingual version available in MLZ, if there is interest. I believe there was one glitch in the original code, relating to journal articles or other content within a container. A diff between the MLZ and mainstream versions should reveal the change. Here's the MLZ translator source:

  https://github.com/fbennett/translators/blob/multi/MODS.js

Frank
 

Stefan Majewski

unread,
Feb 26, 2013, 10:52:41 AM2/26/13
to zoter...@googlegroups.com, Kevin Hawkins
Hi Simon, hi Zotero developers,

I fear I must have missed the discussion on the end of e4x in FF/Zotero. Consequently the translator was apparently dropped on Feb 4th with the following commit:

commit e1f62bc08357b28f024cf1aef7dfb62645bc817e
Author: Simon Kornblith <si...@simonster.com>
Date:   Mon Feb 4 17:19:02 2013 -0500

    Remove TEI
    
    It currently shows up as an export option but doesn't work (E4X)


I would actually be interested to refactor the code such that we can include it again. Are there any model-cases I should have a look at that have undergone analogous refactoring? If so I'd try to do it pretty soon as I have a bug report pending that I also wanted to fix. Any pointers would be highly appreciated.

Kind regards and all the best,

Stefan




2012/7/5 Simon Kornblith <si...@simonster.com>

adamsmith

unread,
Feb 26, 2013, 1:22:01 PM2/26/13
to zoter...@googlegroups.com
I think the MODS translator is probably your best bet. I does import and export so it's quite a bit more complex than what you need, but should give you the general idea.
There are a couple of relevant commits by Simon in the recent history:
https://github.com/zotero/translators/commits/master/MODS.js

Stefan Majewski

unread,
Feb 27, 2013, 11:10:03 AM2/27/13
to zoter...@googlegroups.com
Hi Adam, 

thanks for the pointers. I schedule this for next weekend and will then, as soon as I have fixed and tested it somewhat submit a new pull request. I don't know how to do this for previously deleted files, but I guess I will just put the new version in a newly created fork and let you pull this. The history of the file is lost in this case, though. Or should I approach this differently?

kind regards,

Stefan


2013/2/26 adamsmith <bst...@gmx.de>

--
You received this message because you are subscribed to the Google Groups "zotero-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to zotero-dev+...@googlegroups.com.

To post to this group, send email to zoter...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Avram Lyon

unread,
Feb 27, 2013, 11:44:34 AM2/27/13
to zotero-dev

I think the history will be preserved- it's on a filename basis anyway. Recreate the file or revert its deletion and hack away.

Reply all
Reply to author
Forward
0 new messages