Update translators for CNKI & Wanfang Data

[东东爸]

Hi guys,

This update only fix search page selection bugs, multilingual support is still not implemented.

I post updated sources here: https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/CNKI.js and https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/Wanfang%20Data.js

Any feedback is welcome.
--
Best Regards！

Ace Strong

[Avram Lyon]

Ace,

2010/10/12 东东爸 <aces...@gmail.com>:

> Hi guys,
> This update only fix search page selection bugs, multilingual support is
> still not implemented.
> I post updated sources
> here: https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/CNKI.js and https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/Wanfang%20Data.js

I'll try to review these this evening.

Multilingual support in translators is purely experimental at this
point and there's no guarantee that they won't need to be modified to
work with the final form of the multilingual infrastructure. The
important thing now is to determine what functionality will be
required for translators to work and be written effectively.

- Avram

[东东爸]

Avram,

On Tue, Oct 12, 2010 at 5:01 PM, Avram Lyon <ajl...@gmail.com> wrote:

Ace,

2010/10/12 东东爸 <aces...@gmail.com>:

> Hi guys,
> This update only fix search page selection bugs, multilingual support is
> still not implemented.
> I post updated sources
> here: https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/CNKI.js and https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/Wanfang%20Data.js

I'll try to review these this evening.

Thanks. 

Multilingual support in translators is purely experimental at this
point and there's no guarantee that they won't need to be modified to
work with the final form of the multilingual infrastructure. The
important thing now is to determine what functionality will be
required for translators to work and be written effectively.

You are right, I will read through your discussions about that, then try to comment on it from translator point of view.

--
Best Regards!

Ace Strong

[Avram Lyon]

2010/10/12 东东爸 <aces...@gmail.com>:
>> > Hi guys,
>> > This update only fix search page selection bugs, multilingual support is
>> > still not implemented.
>> > I post updated sources
>> > here:
>> > https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/CNKI.js and
>> > https://bitbucket.org/acestrong/zotero-translators-chn/src/tip/Wanfang%20Data.js

I've committed all three translators. As with CNKI before it, I was
not able to test Wanfang Data, since I didn't have an account, but I
did go through the code. It looks good.

https://www.zotero.org/trac/changeset/7073

- Avram

[东东爸]

Thanks Avram!