Anyone available to review my Discogs translator pull request ?

[Michael Freeman]

Hi, 

Is anyone available to review my PR for a Discogs.com translator ?

Its at … https://github.com/zotero/translators/pull/3451

The main stumbling block was the test conditions but those have now been added.

Would be nice to get this in the main Zotero release as citing music tracks properly has been a neglected area.

Best

Michael

[Abe Jellinek]

You still haven’t pushed any test cases. Once they’re added, you can ping me in the PR comments.

--
You received this message because you are subscribed to the Google Groups "zotero-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to zotero-dev+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/zotero-dev/069052BE-F5EE-4DD2-A8F0-CF4D6647C7C9%40gmail.com.

[Michael Freeman]

My apologies. I’d forgotten to actually update the PR with a new Discogs.js which does have the test cases.

To view this discussion visit https://groups.google.com/d/msgid/zotero-dev/834F56B5-FFB6-4F52-A556-22F22242DCCC%40berkeley.edu.