Possible tiny itembox.xml nit

21 views
Skip to first unread message

Frank Bennett

unread,
Feb 24, 2023, 9:34:57 PM2/24/23
to zotero-dev
While merging Zotero 6.0.20, I was initially thrown by a variable called at line 395:

this.addDateRow(fieldNames[i], this.item.getField(fieldName, true), tabindex);


fieldName is originally assigned from fieldNames[i]. There are no overwriting assignments that I can see, and the call is wrapped in a condition that tests for fieldName. The value of fieldNames[i] and fieldName should be identical, and it should be okay to call fieldName in both slots. I think.


Dan Stillman

unread,
Feb 25, 2023, 1:40:51 AM2/25/23
to zoter...@googlegroups.com
Fixed, thanks.
Reply all
Reply to author
Forward
0 new messages