beta91: deleteing collection before deleting item yields parentCollection.removeItem is not a function

[Emiliano Heyns]

This order works:

let items = await Zotero.Items.getAll(Zotero.Libraries.userLibraryID, false, true, true)
    while (items.length) {
      const chunk = items.splice(0, 100)
      await Zotero.Items.erase(chunk)
    }

    await Zotero.Items.emptyTrash(Zotero.Libraries.userLibraryID)

    for (const collection of (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true) || [])) {
      await collection.eraseTx()
    }

this order fails:

for (const collection of (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true) || [])) {
      await collection.eraseTx()
    }

for (const collection of (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true) || [])) {
      await collection.eraseTx()
    }

[Dan Stillman]

On 6/22/24 6:24 PM, Emiliano Heyns wrote:
> this order fails:
>
> for (const collection of
> (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true)
> || [])) {
>       await collection.eraseTx()
>     }
>
>
> for (const collection of
> (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true)
> || [])) {
>       await collection.eraseTx()
>     }

I don't think think this is what you meant to write?

[Emiliano Heyns]

Oops.

This order works:

  let items = await Zotero.Items.getAll(Zotero.Libraries.userLibraryID, false, true, true)
  while (items.length) {
    const chunk = items.splice(0, 100)
    await Zotero.Items.erase(chunk)
  }

  await Zotero.Items.emptyTrash(Zotero.Libraries.userLibraryID)

  for (const collection of (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true) || [])) {
    await collection.eraseTx()
  }

this order fails:

  for (const collection of (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true) || [])) {
    await collection.eraseTx()
  }

  let items = await Zotero.Items.getAll(Zotero.Libraries.userLibraryID, false, true, true)
  while (items.length) {
    const chunk = items.splice(0, 100)
    await Zotero.Items.erase(chunk)
  }

  await Zotero.Items.emptyTrash(Zotero.Libraries.userLibraryID)

[Dan Stillman]

On 6/22/24 7:28 PM, Emiliano Heyns wrote:
> this order fails:
>
>   for (const collection of
> (Zotero.Collections.getByLibrary(Zotero.Libraries.userLibraryID, true)
> || [])) {
>     await collection.eraseTx()
>   }
>

>   let items = await
> Zotero.Items.getAll(Zotero.Libraries.userLibraryID, false, true, true)
>   while (items.length) {
>     const chunk = items.splice(0, 100)
>     await Zotero.Items.erase(chunk)
>   }
>
>   await Zotero.Items.emptyTrash(Zotero.Libraries.userLibraryID)

That works fine for me.