DragBank.ca web translator

[Tom Hodder]

My first attempt at a web translator for drugbank.ca is here;
https://gist.github.com/2698471


I need to add some tests, and it only captures the drug item types, but its a start...

[Tom Hodder]

I've added a test, and fixed some other fields, I have the file in branch called "drugbank" here;
https://github.com/tolland/translators/blob/drugbank/DrugBank.ca.js

[adamsmith]

thanks!
A couple of things:
- min version should be 2.1.9 for Framework translators.
- you can mark them compatible with Chrome and Safari
- we prefer a license (some version of GPL, ideally AGPL) on the translator - see most existing Framework translators for examples
- I don't understand what the "split" is doing on the url - that doesn't seem to make sense - if you want to remove everything after # and ?, a match(/^.+?[#\?]/) would make more sense.

[Tom Hodder]

I've uploaded a slightly improved version, addressing those points.

I'm still a bit unclear on the date formats and parsing of the text part of elements, so I will take a look through some of the other translators and make some more changes.

Is there some process for code review, rather than submitting pull requests?

[adamsmith]

pull requests are fine - Simon reviews translators before accepting pull requests.
Posting here is also good - in addition to Simon, Aurimas and/or I are pretty likely to take a look. You can also just ask questions here, of course.