OvidSP (ovid) export to zotero translator

[Ovid-Dev]

Hello,

Wolters Kluwer Health (MR) - Ovid(SP) has just posted javascript code
for the ovidsp to zotero export translator.
Please review/test and let us know if there are any issues.


Regards


Srinivas Digumarty


git clone g...@gist.github.com:c27b8b602371a6fb55a1.git gist-c27b8b60

[adamsmith]

sorry, could you clarify where you posted the code?
It's not up as a pull request to zotero/translator and you didn't
provide a link.

[Avram Lyon]

On Sun, Jan 29, 2012 at 12:09 PM, adamsmith <bst...@gmx.de> wrote:
> sorry, could you clarify where you posted the code?
> It's not up as a pull request to zotero/translator and you didn't
> provide a link.

Srinivas did:

git clone g...@gist.github.com:c27b8b602371a6fb55a1.git gist-c27b8b60

Not the only way to do this, but that'll work. Thanks for putting this
together; and we'll try to get this reviewed and out to clients
quickly.

In addition to the code review that we do, we also need some sort of
statement licensing your contribution to this code under an
appropriate license for distribution with Zotero; we generally expect
that new code will be provided under the Affero GPL v3
(http://www.gnu.org/licenses/agpl.html); can you confirm that your
contribution and Wolters Kluwer/Ovid's contribution to the translator
is provided under those terms?

Best wishes,

Avram

[adamsmith]

> Srinivas did:
> git clone g...@gist.github.com:c27b8b602371a6fb55a1.git gist-c27b8b60

sorry, got mangled in my message display.

[adamsmith]

I had a quick test run and it works quite well.
One issue I found is that the last author in BIOSIS items such as this
one:
http://ovidsp.ovid.com/ovidweb.cgi?T=JS&CSC=Y&NEWS=N&PAGE=fulltext&D=biop30&AN=PREV200400464367
still has part of what you call "weird field codes" - as in
"Vilhelm A. [Author"
the problem here seems to me that the full field is
Bohr, Vilhelm A. [Author, Reprint Author; E-mail: vb...@nih.gov]
and so the split in l. 163 doesn't turns this into an array with
length 3 and so the if names.length==2 in l. 167 doesn't detect it.

On Jan 27, 12:28 pm, Ovid-Dev <srinivas.diguma...@gmail.com> wrote:

[Ovid-Dev]

Hi Adam

I just posted a newer version of the Zotero translator code.


https://gist.github.com/c27b8b602371a6fb55a1
OR

git clone g...@gist.github.com:c27b8b602371a6fb55a1.git gist-c27b8b60

This should be the latest version from our development team.
Please let me know if you are still experiencing any problems.

Regards


--Srini

On Jan 30, 12:01 pm, adamsmith <bst...@gmx.de> wrote:
> I had a quick test run and it works quite well.
> One issue I found is that the last author in BIOSIS items such as this

> one:http://ovidsp.ovid.com/ovidweb.cgi?T=JS&CSC=Y&NEWS=N&PAGE=fulltext&D=...

[adamsmith]

Srini,
I'm still having the same issue I describe above - I also don't see
any changes in the code that would fix it. Let me know if you have
problems replicating it.

Also, and more importantly, we need to know about the license as per
Avram's request above. As he says, most other translators are AGPL
licensed and we'd have a strong preference for that - would that be
OK?

Best,
Sebastian

[adamsmith]

Srini,
we really want to get this up, but we need to hear back about
licensing before we can. Any chance you could get back to us on that?

Also, as noted before, the new version you posted did not fix the
issue I reported, no. It's not a majore problem, though it would
obviously be nice to get it fixed.
Best,
Sebastian (adamsmith)

On Jan 31, 8:46 am, Ovid-Dev <srinivas.diguma...@gmail.com> wrote:

[adamsmith]

Srini,
any news on this?
I'd love to get this going and I think we're all happy to put the
translator up even if minor issues remain - but we need to hear about
licensing.
Thank you in advance and best,
Sebastian

On Jan 31, 8:46 am, Ovid-Dev <srinivas.diguma...@gmail.com> wrote:

> Hi Adam
>
> I just posted a newer version of the Zotero translator code.
>
> https://gist.github.com/c27b8b602371a6fb55a1
> OR
> git clone g...@gist.github.com:c27b8b602371a6fb55a1.git gist-c27b8b60
>
> This should be the latest version from our development team.
> Please let me know if you are still experiencing any problems.
>
> Regards
>
> --Srini
>
> On Jan 30, 12:01 pm, adamsmith <bst...@gmx.de> wrote:
>
>
>
>
>
>
>
> > I had a quick test run and it works quite well.
> > One issue I found is that the last author in BIOSIS items such as this
> > one:http://ovidsp.ovid.com/ovidweb.cgi?T=JS&CSC=Y&NEWS=N&PAGE=fulltext&D=...
> > still has part of what you call "weird field codes" - as in
> > "Vilhelm A. [Author"
> > the problem here seems to me that the full field is
> > Bohr, Vilhelm A. [Author, Reprint Author; E-mail: vb...@nih.gov]
> > and so the split in l. 163 doesn't turns this into an array with
> > length 3 and so the if names.length==2 in l. 167 doesn't detect it.
>

> > On Jan 27, 12:28 pm,Ovid-Dev <srinivas.diguma...@gmail.com> wrote:
>
> > > Hello,
>

> > > Wolters Kluwer Health (MR) -Ovid(SP) has just posted javascript code

[Ovid-Dev]

Hello,

Wolters Kluwer Health (MR/Ovid) - Ovid(SP) has just updated their zotero translator to include the GNU Affero GPL 3 licence preamble.

The licence change and latest code can be retrieved from here:

https://gist.github.com/06c057e4e7c7813689ae

We are aware of minor issues regarding the author exports, we have a fix in place but will be releasing it as part of corresponding fix on the 

ovidsp platform.

Regards

Srinivas DIgumarty

[adamsmith]

Wonderful - thank you.
I've tested this and fixed/cleaned some small things (the license needs to come after the translator metadata; there was a debug in the detectWeb that caused some trouble; there is no need to define a namespace in functions - for doc.evaluate it can just be set to null).
I've issued a pull request here
https://github.com/zotero/translators/pull/205
Simon will do a final round of reviewing and then include this in the Zotero repository, from which it will automatically update to clients within 24hs.