[Zope-CMF] 2.3
Charlie Clark
I finally landed my update step for syndication during the PyCon sprints!
I thought I had a few more browser views to update to using the
EditSettingsForm but on a quick check of the files it seems that this has
already been done. Yuppie, I remember that you have commented out some of
my views (portal configuration and membership, I think) because of the
encoding problem, did you correct them yourself last year and I was simply
looking at old source? If that is the case then I think we're good to go
with 2.3.
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
_______________________________________________
Zope-CMF maillist - Zope...@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Jens Vagelpohl
On Mar 20, 2012, at 16:14 , Charlie Clark wrote:
> Hi,
>
> I finally landed my update step for syndication during the PyCon sprints! I thought I had a few more browser views to update to using the EditSettingsForm but on a quick check of the files it seems that this has already been done. Yuppie, I remember that you have commented out some of my views (portal configuration and membership, I think) because of the encoding problem, did you correct them yourself last year and I was simply looking at old source? If that is the case then I think we're good to go with 2.3.
If there are no objections I could run through the packages and create 2.3.0 betas later this week or this coming weekend.
jens
Tres Seaver
Hash: SHA1
On 03/20/2012 06:25 PM, Jens Vagelpohl wrote:
>
> On Mar 20, 2012, at 16:14 , Charlie Clark wrote:
>
>> I finally landed my update step for syndication during the PyCon
>> sprints! I thought I had a few more browser views to update to
>> using the EditSettingsForm but on a quick check of the files it
>> seems that this has already been done. Yuppie, I remember that you
>> have commented out some of my views (portal configuration and
>> membership, I think) because of the encoding problem, did you
>> correct them yourself last year and I was simply looking at old
>> source? If that is the case then I think we're good to go with 2.3.
>
> If there are no objections I could run through the packages and
> create 2.3.0 betas later this week or this coming weekend.
Sounds good. We should review the code for any stuff
deprecated-and-promised-to-be-remove-in-2.3 before releasing a beta.
Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tse...@palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk9pFIQACgkQ+gerLs4ltQ5/qgCgjqblk/uMP2vW1hYksFNvCFXC
8ocAn0ZQzSfmr1EgI5AbNtl6h1KyoU6R
=XfEn
-----END PGP SIGNATURE-----
Charlie Clark
> Sounds good. We should review the code for any stuff
> deprecated-and-promised-to-be-remove-in-2.3 before releasing a beta.
I suppose we could also migrate the old Zope Help docs to "docs" for
Sphinx generation? I know much of the docs are inaccurate and outdated but
this might help expose the worst bits which should then be exorcised or at
least pruned.
Not sure if this would be for 2.3 but I think that CMFCalendar should be
rolled into CMFDefault. The main reason being that the default profile for
CMFCalendar uses browser views and explicitly requires the CMFDefault skin
layer. You then can't use CMFCalendar if you override the default skin
layer. Plus, CMFCalendar's functionality is extremely limited and
intimately tied to CMFDefault.
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Jens Vagelpohl
On Mar 21, 2012, at 15:55 , Charlie Clark wrote:
> Am 21.03.2012, 00:36 Uhr, schrieb Tres Seaver <tse...@palladion.com>:
>
>> Sounds good. We should review the code for any stuff
>> deprecated-and-promised-to-be-remove-in-2.3 before releasing a beta.
>
> I suppose we could also migrate the old Zope Help docs to "docs" for
> Sphinx generation? I know much of the docs are inaccurate and outdated but
> this might help expose the worst bits which should then be exorcised or at
> least pruned.
>
> Not sure if this would be for 2.3 but I think that CMFCalendar should be
> rolled into CMFDefault. The main reason being that the default profile for
> CMFCalendar uses browser views and explicitly requires the CMFDefault skin
> layer. You then can't use CMFCalendar if you override the default skin
> layer. Plus, CMFCalendar's functionality is extremely limited and
> intimately tied to CMFDefault.
If we keep piling up tasks that are too big to be tackled in a small amount of time as part of the release process we'll never get anything released. I would classify both these items as "nice to have, but not on the critical path".
jens
Charlie Clark
> If we keep piling up tasks that are too big to be tackled in a small
> amount of time as part of the release process we'll never get anything
> released. I would classify both these items as "nice to have, but not on
> the critical path".
True. I've done a *very* basic port of the docs to ReST so that Sphinx
will at least generate stuff. This has been done by copying the exiting
STX files and renaming them. Should they be moved instead to preserve the
history?
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Jens Vagelpohl
On Mar 20, 2012, at 23:25 , Jens Vagelpohl wrote:
>
> On Mar 20, 2012, at 16:14 , Charlie Clark wrote:
>
>> Hi,
>>
>> I finally landed my update step for syndication during the PyCon sprints! I thought I had a few more browser views to update to using the EditSettingsForm but on a quick check of the files it seems that this has already been done. Yuppie, I remember that you have commented out some of my views (portal configuration and membership, I think) because of the encoding problem, did you correct them yourself last year and I was simply looking at old source? If that is the case then I think we're good to go with 2.3.
>
>
> If there are no objections I could run through the packages and create 2.3.0 betas later this week or this coming weekend.
The beta eggs are released now.
Charlie Clark
> The beta eggs are released now.
Great, thanks!
I'm testing with some existing sites and getting the following error even
before I run the upgrades:
ComponentLookupError: (<InterfaceClass
Products.CMFCore.interfaces._tools.IURLTool>, '')
I'm obviously missing a registration but my site includes Products.CMFCore
package.
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Ruslan Mahmatkhanov
> ComponentLookupError: (<InterfaceClass
> Products.CMFCore.interfaces._tools.IURLTool>, '')
>
> I'm obviously missing a registration but my site includes
> Products.CMFCore package.
>
> Charlie
Sorry for offtopic, but since I'm fighting with similar error (not
related to new CMF and CMF at all) hope you don't mind if I ask it there:
ComponentLookupError:
((<Products.Five.metaclass.DirContainedFileResource5 object at
0x2db87acc>, <HTTPRequest,
URL=http://localhost:8080/Plone/portal_css/Sunburst%20Theme/++resource++plone.app.discussion.stylesheets/discussion.css>),
<InterfaceClass zope.browserresource.interfaces.IETag>, u'')
What this message actually mean? Can you please direct me what should I
look for? You mentioned "missing registration" - can you please disclose
this process in some details? Thank you in advance!
--
Regards,
Ruslan
Tinderboxing kills... the drives.
Charlie Clark
> Sorry for offtopic, but since I'm fighting with similar error (not
> related to new CMF and CMF at all) hope you don't mind if I ask it there:
> ComponentLookupError:
> ((<Products.Five.metaclass.DirContainedFileResource5 object at
> 0x2db87acc>, <HTTPRequest,
> URL=http://localhost:8080/Plone/portal_css/Sunburst%20Theme/++resource++plone.app.discussion.stylesheets/discussion.css>),
> <InterfaceClass zope.browserresource.interfaces.IETag>, u'')
Hi Ruslan,
apart from telling you that something hasn't been registered I can't
really help you on this. It looks like the ETag cache info can't be set
but you'll need to talk to the Plone people for more information.
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
yuppie
Charlie Clark wrote:
> I'm testing with some existing sites and getting the following error
> even before I run the upgrades:
>
> ComponentLookupError: (<InterfaceClass
> Products.CMFCore.interfaces._tools.IURLTool>, '')
>
> I'm obviously missing a registration but my site includes
> Products.CMFCore package.
The tools are *local* utilities. Including the ZCML doesn't fix this
issue. You have to run the upgrade step.
It should be possible to use the ZMI without this kind of errors. In
some places I added fallbacks like this one:
try:
utool = getUtility(IURLTool)
except ComponentLookupError:
# BBB: fallback for CMF 2.2 instances
utool = aq_get(self, 'portal_url')
If you can't run the upgrades from the ZMI it might be necessary to add
more fallbacks in CMF.
HTH,
Yuppie
Charlie Clark
> The tools are *local* utilities. Including the ZCML doesn't fix this
> issue. You have to run the upgrade step.
> It should be possible to use the ZMI without this kind of errors. In
> some places I added fallbacks like this one:
> try:
> utool = getUtility(IURLTool)
> except ComponentLookupError:
> # BBB: fallback for CMF 2.2 instances
> utool = aq_get(self, 'portal_url')
> If you can't run the upgrades from the ZMI it might be necessary to add
> more fallbacks in CMF.
Hi Yuppie,
thanks for the quick and informative reply. On both of my test sites I've
not been able to look at the site in the ZMI without getting the errors.
Even running Site/portal_setup fails. FWIW both sites are using the ursa
globals. I can try patching this in the way you suggest and then see how
the upgrade works.
Charlie
PS. I've just run tests on trunk and am getting failures in CMFCore:
Failure in test test_getActionObject_oldskool_action_deprecated
(Products.CMFCore.tests.test_ActionsTool.ActionsToolTests)
Traceback (most recent call last):
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 327, in run
testMethod()
File
"/Users/charlieclark/Sites/CMF/src/Products.CMFCore/Products/CMFCore/tests/test_ActionsTool.py",
line 99, in test_getActionObject_oldskool_action_deprecated
'2.4. Use Action and Action Category objects instead.' in warning)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 608, in deprecated_func
return original_func(*args, **kwargs)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 420, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true
Failure in test test_getDiff
(Products.CMFCore.tests.test_FSPythonScript.CustomizedPythonScriptTests)
Traceback (most recent call last):
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 327, in run
testMethod()
File
"/Users/charlieclark/Sites/CMF/src/Products.CMFCore/Products/CMFCore/tests/test_FSPythonScript.py",
line 269, in test_getDiff
self.assertEqual(list(cps.getDiff()), _DIFF_TEXT.splitlines())
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 509, in assertEqual
assertion_func(first, second, msg=msg)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 738, in assertListEqual
self.assertSequenceEqual(list1, list2, msg, seq_type=list)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 720, in assertSequenceEqual
self.fail(msg)
File
"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 408, in fail
raise self.failureException(msg)
AssertionError: Lists differ: ['--- original', '+++ modified... != ['---
original ', '+++ modifie...
First differing element 0:
--- original
--- original
- ['--- original',
+ ['--- original ',
? +
- '+++ modified',
+ '+++ modified ',
? +
'@@ -7,4 +7,4 @@',
' ##parameters=',
' ##title=',
' ##',
"-return 'cps'",
"+return 'cps -- replaced'"]
Ran 219 tests with 2 failures and 0 errors in 3.376 seconds.
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Jens Vagelpohl
On Mar 22, 2012, at 13:42 , Charlie Clark wrote:
> PS. I've just run tests on trunk and am getting failures in CMFCore:
The tests only fail on Python 2.7, they run through fine on 2.6. As such, they're not functional failures but failures dur to changes in behavior between 2.6 and 2.7. In one place a DeprecationWarning is not written to the log, in another diff output has changed slightly.
jens
Charlie Clark
> The tests only fail on Python 2.7, they run through fine on 2.6. As
> such, they're not functional failures but failures dur to changes in
> behavior between 2.6 and 2.7. In one place a DeprecationWarning is not
> written to the log, in another diff output has changed slightly.
Thanks, Jens. I'd forgotten I'd made Python 2.7 my default.
Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Charlie Clark
> The beta eggs are released now.
Jens,
could we have a patch release to include my fallbacks? I'd like to be able
to try the beta with a couple of other sites without adding links to trunk
in my buildouts.
Charlie
PS. We should probably try and avoid an April 1st release! ;-)
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
Jens Vagelpohl
On Mar 31, 2012, at 17:03 , Charlie Clark wrote:
> Am 21.03.2012, 22:58 Uhr, schrieb Jens Vagelpohl <je...@dataflake.org>:
>
>> The beta eggs are released now.
>
> Jens,
>
> could we have a patch release to include my fallbacks? I'd like to be able to try the beta with a couple of other sites without adding links to trunk in my buildouts.
Products.CMFCore and Products.CMFDefault are now released as version 2.3.0-beta2
jens
Charlie Clark
Am 03.04.2012, 14:11 Uhr, schrieb yuppie <y.2...@wcm-solutions.de>:
> +1
> Is CMFDefault/help now obsolete? Could it be deleted?
I guess so. I'm still working on "tidying" up what can loosely be termed
as the narrative documentation. Still in the clean-up phase but should get
this done this week.
@ Jens will we be able to point the release to a docs page on Zope.org?
I had a go at autogenerating the api documentation but failed miserably -
lots of empty pages got generated because Sphinx had trouble with import
paths. Does anyone know the appropriate incantations for this?
> Not sure if this would be for 2.3 but I think that CMFCalendar should be
> rolled into CMFDefault. The main reason being that the default profile
> for
> CMFCalendar uses browser views and explicitly requires the CMFDefault
> skin
> layer. You then can't use CMFCalendar if you override the default skin
> layer. Plus, CMFCalendar's functionality is extremely limited and
> intimately tied to CMFDefault.
> -1
> CMFCalendar is an example add-on. It should be possible to write
> add-ons like CMFCalendar. So if there are any issues with keeping it in
> a separate optional package they should be fixed instead of giving up.
Okay. I guess the key issue is making working with Zope-3 skins easier.
I'd like to have a different CMFDefault profile that did without CMF skins
(yes, I do appreciate the irony), ie. the ability to jetison PythonScripts
et al. CMFCalendar won't work with that because of the explicit dependency
upon the CMF skin layer. Certainly a big enough change not to be in 2.3.
Jens Vagelpohl
On Apr 3, 2012, at 14:55 , Charlie Clark wrote:
> Am 03.04.2012, 14:11 Uhr, schrieb yuppie <y.2...@wcm-solutions.de>:
>
>> +1
>> Is CMFDefault/help now obsolete? Could it be deleted?
>
> I guess so. I'm still working on "tidying" up what can loosely be termed as the narrative documentation. Still in the clean-up phase but should get this done this week.
>
> @ Jens will we be able to point the release to a docs page on Zope.org?
*If* there's a working Sphinx documentation set under Products.CMFXXX/doc or Products.CMFXXX/docs I can stitch it into the autogenerated documentation at docs.zope.org.
> I had a go at autogenerating the api documentation but failed miserably - lots of empty pages got generated because Sphinx had trouble with import paths. Does anyone know the appropriate incantations for this?
I can take a look over the next few days.
jens