[Bug 301037] [NEW] Objects store reactor references.

1 view
Skip to first unread message

Ross Light

unread,
Nov 22, 2008, 12:18:35 PM11/22/08
to zfn...@googlegroups.com
Public bug reported:

In ZFN, all objects requiring the use of the reactor have stored a
reference to the reactor. This is unnecessary, since Twisted maintains
a global reactor object. I did not realize this during development, and
as such, many objects have a redundant reactor attribute.

I propose creating a get_reactor function in the util module so that we
don't have to import reactor (thus automatically selecting the type of
reactor) until the last possible moment.

** Affects: zfilenet
Importance: Medium
Assignee: Ross Light (quartz25)
Status: Confirmed


** Tags: maintenance

** Changed in: zfilenet
Importance: Undecided => Medium
Assignee: (unassigned) => Ross Light (quartz25)
Status: New => Confirmed
Target: None => 0.3.0a1

--
Objects store reactor references.
https://bugs.launchpad.net/bugs/301037
You received this bug notification because you are a member of ZFN
Developers, which is subscribed to ZFN.

Status in ZFN: Confirmed

Bug description:
In ZFN, all objects requiring the use of the reactor have stored a reference to the reactor. This is unnecessary, since Twisted maintains a global reactor object. I did not realize this during development, and as such, many objects have a redundant reactor attribute.

I propose creating a get_reactor function in the util module so that we don't have to import reactor (thus automatically selecting the type of reactor) until the last possible moment.

Ross Light

unread,
Nov 22, 2008, 1:17:07 PM11/22/08
to zfn...@googlegroups.com
** Changed in: zfilenet
Status: Confirmed => In Progress

--
Objects store reactor references.
https://bugs.launchpad.net/bugs/301037
You received this bug notification because you are a member of ZFN
Developers, which is subscribed to ZFN.

Status in ZFN: In Progress

Ross Light

unread,
Nov 22, 2008, 1:41:17 PM11/22/08
to zfn...@googlegroups.com
Fixed in trunk r193

** Changed in: zfilenet
Status: In Progress => Fix Committed

** Summary changed:

- Objects store reactor references.
+ Objects store reactor references

--
Objects store reactor references


https://bugs.launchpad.net/bugs/301037
You received this bug notification because you are a member of ZFN
Developers, which is subscribed to ZFN.

Status in ZFN: Fix Committed

Ross Light

unread,
Nov 22, 2008, 1:43:04 PM11/22/08
to zfn...@googlegroups.com
Fixed in 0.3 r196

--
Objects store reactor references

https://bugs.launchpad.net/bugs/301037
You received this bug notification because you are a member of ZFN
Developers, which is subscribed to ZFN.

Status in ZFN: Fix Committed

Reply all
Reply to author
Forward
0 new messages