Commenting out Zest statements

[Simon Bennetts]

What does everyone think about having an option to comment out any Zest statement?
So this would be a boolean attribute on every statement, possibly "comment" ;)
The default would be false, but if you set it to true then the statement will be treated like a comment, ie ignored.
If the statement is a container (eg a conditional or loop) then all of the contained statements will also be commented.

In ZAP I'd add a right click "Comment/Uncomment" menu option, and then either grey out the icon or something similar.
Having played around with quite a few Zest scripts I think this would be a useful enhancement.

Silence will be taken to imply approval ;)

Cheers,

Simon

[Lars Kristensen]

Hi Simon,

I definetly think this would be useful - at least for debugging purposes. While we were developing our extension for ZAP, we had several different ZEST scripts that did almost the same thing, with minor differences. It would be great if it was possible to store everything in one script, and simply toggle which parts should run, by commenting/uncommenting different parts :)

- Lars

[Sunny]

+1

[Frederik Braun]

Replying a bit late and possibly bike-shedding:

But I'd call it "disable" or "skip" :-) And in the UI use the typical
pattern to display entries in grey on white, instead of black on white.

[Simon Bennetts]

How about "enabled", again defaulting to true?
In java the methods would then end up isEnabled() and setEnabled(boolean enabled) which are nice and understandable.

And yes, grey on white makes sense.

[Frederik Braun]

That sounds very reasonable :)

[Simon Bennetts]

I've committed these changes to the Zest repo and also the related ZAP UI changes.
They seem to work well :)
I'm not planning on releasing the ZAP Zest add-on until theres a fix for the Selenium issue which means it doesnt work with Firefox 32.0 :/

Simon

[Sunny]

I have added this support to Firefox Zest add-on.

Sunny

[Sunny]

[Simon Bennetts]

Great!

Selenium have fixed the issue with Firefox 32.0 so I've just released a new ZAP Zest add-on.
If you use this then make sure you also update the Scripts add-on - these 2 new versions then provide drag-and-drop support for editing Zest scripts :)

Cheers,

Simon