External dependencies in Add-on, does ZAP Core need a declaration?

[하훌 HAHWUL]

Hi ZAP Developers! 

I'm make an addon now, I have one questions.

If I need to refer to an external dependencies in addon, does the zap core require implementation in dependency(zap.gradle.kts)?

## History 

I applied it to the ZAP core and sent PR it before, There was feedback that it would be good to do it on add-on, and I'm only starting work now.

- https://twitter.com/hahwul/status/1346615689247801344

However, when I tried to bring up the part where I added look and feel in addon, "Failed to set the look and feel" occurred.

## Logs

intellijthemes.gradle.kts

in addon code

in zap 

when change theme, boom error

[thc...@gmail.com]

Hi.

The look and feels (L&Fs) would have to be set using the add-on class
loader to be able to find the add-on's L&Fs/classes.

Might be better to change core to explicitly allow add-ons to provide
L&Fs to properly manage them (e.g. set with correct class loader, unset
L&F and remove them when the add-on is uninstalled…).

Best regards.

[하훌 HAHWUL]

Thank you for your answer! It's a more complicated situation than I thought 😵‍💫 

2022년 3월 14일 월요일 오전 12시 4분 10초 UTC+9에 thc202님이 작성:

[thc...@gmail.com]

Instead of adding to the main list of L&Fs you could create a new button
and set the L&Fs yourself using the appropriate class loader.
That would require less changes and could be released sooner as an add-on.

Would you be interested in doing that?

Best regards.

[하훌 HAHWUL]

Yes! I think it's better to set Intellij L&Fs as a new button than the main list.

I was making add-on(only my env, similar theme-pack), which expands the main list, but I stopped because the implementation was complicated and the design didn't look good. 😭 

If it has to be made into a new add-on, so I hope a competent person can solve it 🙏

2022년 4월 30일 토요일 오전 1시 50분 45초 UTC+9에 thc202님이 작성:

[kingthorin+owaspzap]

Just to be clear, are you going to redirect the design of your add-on or are you hoping someone else will pickup the idea and tackle it?

[HAHWUL]

Okay, yes! I'll change the code and design in my add-on source. I will send you a Pull-Request when it is completed.
It was nice talking to you :D

You're the best.

2022년 5월 2일 (월) 오전 10:04, kingthorin+owaspzap <kingt...@gmail.com>님이 작성:

>>> [image: 스크린샷 2022-03-13 오후 10.43.00.png]
>>>
>>> in addon code
>>> [image: 스크린샷 2022-03-13 오후 10.43.06.png]
>>>
>>> in zap
>>> [image: 스크린샷 2022-03-13 오후 10.43.28.png]

>>>
>>> when change theme, boom error

>>> [image: 스크린샷 2022-03-13 오후 10.42.44.png]
>>>
>>>
>>
>

--
You received this message because you are subscribed to a topic in the Google Groups "OWASP ZAP Developer Group" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/zaproxy-develop/XjNbqLKKoMU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to zaproxy-devel...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/zaproxy-develop/9c283fb6-72d2-4a6e-8af2-9387a5845e4an%40googlegroups.com.

[kingthorin+owaspzap]

Wonderful, thank Hahwul!

Let us know if you get stuck or need advice :)