yubikey-personalization 1.5.1

15 views
Skip to first unread message

Simon Josefsson

unread,
Apr 11, 2011, 9:39:39 AM4/11/11
to yubico...@googlegroups.com
Hi! I have released yubikey-personalization 1.5.1 with these fixes:

** Added native Windows backend.
It is used automatically when building with a Mingw compiler, but you
use --with-backend=windows to request it.

** Distribute ykdef.h needed by challenge-response applications.

** Bugfixes :

*** Fixed a crash in the self test on 64-bit platforms.

*** Fixed a build error in self tests when "-z muldefs" is not supported.

*** -ofixed= was incorrectly excluded from pretty-printing of configuration
for OATH-HOTP.

*** Configuring slot 2 was broken on Windows.

Thanks to Tollef and Fredrik and anyone else who helped with this
release that I may have forgotten.

Source code:

http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1.tar.gz
http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1.tar.gz.sig

Pre-compiled Windows 32-bit binaries:

http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1-win32.zip
http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1-win32.zip.sig

Pre-compiled Windows 64-bit binaries:

http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1-win64.zip
http://yubikey-personalization.googlecode.com/files/ykpers-1.5.1-win64.zip.sig

/Simon

Tollef Fog Heen

unread,
Apr 11, 2011, 10:08:33 AM4/11/11
to yubico...@googlegroups.com
]] Simon Josefsson

| Hi! I have released yubikey-personalization 1.5.1 with these fixes:

Great! :-)

Any reason my suggested udev rules werent included? (They've just been
tested on my laptop where they seem to work for me, so it might be they
don't work correctly in all cases or whatever, I don't know.)

Regards,
--
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are

Simon Josefsson

unread,
Apr 11, 2011, 10:24:39 AM4/11/11
to yubico...@googlegroups.com
Tollef Fog Heen <tfh...@err.no> writes:

> ]] Simon Josefsson
>
> | Hi! I have released yubikey-personalization 1.5.1 with these fixes:
>
> Great! :-)
>
> Any reason my suggested udev rules werent included? (They've just been
> tested on my laptop where they seem to work for me, so it might be they
> don't work correctly in all cases or whatever, I don't know.)

I confess I totally missed this -- did you suggest a patch on this? I'm
not sure we want 'make install' to install it, since udev is quite
platform specific. Maybe simplest to just distribute the udev rule, and
let your debian packaging install it in the right place?

Anyway, skipping this wasn't intentional, we just wanted to get the
Windows stuff out since we need that internally. Let's do a quick 1.5.2
with your udev rule too. I guess there will be some other fixes
necessary anyway since this was a rather rushed release...

/Simon

Fredrik Thulin

unread,
Apr 11, 2011, 10:27:25 AM4/11/11
to yubico...@googlegroups.com, Tollef Fog Heen
On Mon, Apr 11, 2011 at 4:08 PM, Tollef Fog Heen <tfh...@err.no> wrote:
> ]] Simon Josefsson
>
> | Hi!  I have released yubikey-personalization 1.5.1 with these fixes:
>
> Great! :-)
>
> Any reason my suggested udev rules werent included?  (They've just been
> tested on my laptop where they seem to work for me, so it might be they
> don't work correctly in all cases or whatever, I don't know.)

No reason with a thought associated with it, no =).

In my mind that was something natural for the Debian package to add
(no need for udev rules on Windows for example), but I have no problem
at all including the file it in the base distribution if you think
that is more suitable. Please commit it where you see fit and we'll
get it into the next release.

/Fredrik

Tollef Fog Heen

unread,
Apr 11, 2011, 4:14:37 PM4/11/11
to yubico...@googlegroups.com
]] Simon Josefsson

| Tollef Fog Heen <tfh...@err.no> writes:
|
| > ]] Simon Josefsson
| >
| > | Hi! I have released yubikey-personalization 1.5.1 with these fixes:
| >
| > Great! :-)
| >
| > Any reason my suggested udev rules werent included? (They've just been
| > tested on my laptop where they seem to work for me, so it might be they
| > don't work correctly in all cases or whatever, I don't know.)
|
| I confess I totally missed this -- did you suggest a patch on this? I'm
| not sure we want 'make install' to install it, since udev is quite
| platform specific. Maybe simplest to just distribute the udev rule, and
| let your debian packaging install it in the right place?

It should probably just be installed to /lib/udev/rules.d if you're on
Linux. I didn't send an explicit patch, just the contents of the rules
file. I'll commit it when I find the time, then. :-)

| Anyway, skipping this wasn't intentional, we just wanted to get the
| Windows stuff out since we need that internally. Let's do a quick 1.5.2
| with your udev rule too. I guess there will be some other fixes
| necessary anyway since this was a rather rushed release...

Ok, no worries. :-)

Simon Josefsson

unread,
Apr 11, 2011, 4:33:49 PM4/11/11
to yubico...@googlegroups.com
Tollef Fog Heen <tfh...@err.no> writes:

> ]] Simon Josefsson
>
> | Tollef Fog Heen <tfh...@err.no> writes:
> |
> | > ]] Simon Josefsson
> | >
> | > | Hi! I have released yubikey-personalization 1.5.1 with these fixes:
> | >
> | > Great! :-)
> | >
> | > Any reason my suggested udev rules werent included? (They've just been
> | > tested on my laptop where they seem to work for me, so it might be they
> | > don't work correctly in all cases or whatever, I don't know.)
> |
> | I confess I totally missed this -- did you suggest a patch on this? I'm
> | not sure we want 'make install' to install it, since udev is quite
> | platform specific. Maybe simplest to just distribute the udev rule, and
> | let your debian packaging install it in the right place?
>
> It should probably just be installed to /lib/udev/rules.d if you're on
> Linux.

I would prefer if this was conditioned on some --with-udev-rule or
similar configure parameter, to avoid automatic installation on non-udev
systems.

> I didn't send an explicit patch, just the contents of the rules
> file. I'll commit it when I find the time, then. :-)

Please do!

/Simon

Greg Woods

unread,
Apr 11, 2011, 4:51:03 PM4/11/11
to yubico...@googlegroups.com
On Mon, 2011-04-11 at 22:14 +0200, Tollef Fog Heen wrote:

> It should probably just be installed to /lib/udev/rules.d if you're on
> Linux.

Not for all Linux unfortunately. On Red Hat derived systems (Fedora,
CentOS, RHEL), the rules are in /etc/udev/rules.d

--Greg


Simon Josefsson

unread,
Apr 12, 2011, 3:40:26 AM4/12/11
to yubico...@googlegroups.com
Greg Woods <wo...@ucar.edu> writes:

Maybe a --with-udev=/lib/udev/rules.d or --with-udev=/etc/udev/rules.d
parameter is a good idea then? I'd rather have this step rather manual
than guessing something that may be wrong -- people packaging this will
know better than we do about udev rule location on various systems.

/Simon

Tollef Fog Heen

unread,
Apr 12, 2011, 7:52:08 AM4/12/11
to yubico...@googlegroups.com
]] Greg Woods

No, they're not. The system udev rules live in /lib, any provided by
the admin can go into /etc. (RHEL5 and CentoOS5 might not have this
yet, since they're fairly old, but it's certainly the norm nowadays.)

Simon Josefsson

unread,
Apr 12, 2011, 8:46:46 AM4/12/11
to yubico...@googlegroups.com
Tollef Fog Heen <tfh...@err.no> writes:

> ]] Greg Woods
>
> | On Mon, 2011-04-11 at 22:14 +0200, Tollef Fog Heen wrote:
> |
> | > It should probably just be installed to /lib/udev/rules.d if you're on
> | > Linux.
> |
> | Not for all Linux unfortunately. On Red Hat derived systems (Fedora,
> | CentOS, RHEL), the rules are in /etc/udev/rules.d
>
> No, they're not. The system udev rules live in /lib, any provided by
> the admin can go into /etc. (RHEL5 and CentoOS5 might not have this
> yet, since they're fairly old, but it's certainly the norm nowadays.)

That's good -- however I just realized that our package should never
install anything outside of $prefix except if explicitly told to do so,
so I would strongly prefer a --with-udev parameter that took an explicit
path. If you push the udev file itself, I'm sure we can help with the
autoconf/automake part if you want.

/Simon

Greg Woods

unread,
Apr 12, 2011, 9:29:32 AM4/12/11
to yubico...@googlegroups.com
On Tue, 2011-04-12 at 13:52 +0200, Tollef Fog Heen wrote:
> On Red Hat derived systems (Fedora,
> | CentOS, RHEL), the rules are in /etc/udev/rules.d
>
> No, they're not. The system udev rules live in /lib, any provided by
> the admin can go into /etc. (RHEL5 and CentoOS5 might not have this
> yet, since they're fairly old, but it's certainly the norm nowadays.)

My shiny new Fedora 14 box has rules in both /etc/udev/rules.d
and /lib/udev/rules.d as provided by the distro.

--Greg

Tollef Fog Heen

unread,
Apr 12, 2011, 4:30:11 PM4/12/11
to yubico...@googlegroups.com
]] Greg Woods

That probably means not all packages have migrated to using
/lib/udev/rules.d or they consider some of the shipped rules as editable
by the admin.

Tollef Fog Heen

unread,
Apr 14, 2011, 4:43:18 PM4/14/11
to yubico...@googlegroups.com
]] Simon Josefsson

| I would prefer if this was conditioned on some --with-udev-rule or
| similar configure parameter, to avoid automatic installation on non-udev
| systems.

https://github.com/tfheen/yubikey-personalization/commit/e61b9ea8deaaa140623b8ff40bd857df0167cb0a
does this.

(I think having:

AC_ARG_WITH([udevrulesdir],
AS_HELP_STRING([--with-udevrulesdir=DIR], [Diectory for udev rules]),
[],
[with_udevrulesdir=`pkg-config --variable=udevdir udev`/rules.d])

instead would be fine, but you don't want that, so I'm not going to push
it further).

Please pull my patch, it seems like I can't push to the Yubico repo
myself.

Regards,

Simon Josefsson

unread,
Apr 20, 2011, 12:52:01 PM4/20/11
to yubico...@googlegroups.com
Tollef Fog Heen <tfh...@err.no> writes:

> ]] Simon Josefsson
>
> | I would prefer if this was conditioned on some --with-udev-rule or
> | similar configure parameter, to avoid automatic installation on non-udev
> | systems.
>
> https://github.com/tfheen/yubikey-personalization/commit/e61b9ea8deaaa140623b8ff40bd857df0167cb0a
> does this.

Thanks! I think Fredrik pushed this already.

> (I think having:
>
> AC_ARG_WITH([udevrulesdir],
> AS_HELP_STRING([--with-udevrulesdir=DIR], [Diectory for udev rules]),
> [],
> [with_udevrulesdir=`pkg-config --variable=udevdir udev`/rules.d])
>
> instead would be fine, but you don't want that, so I'm not going to push
> it further).

That seems rather safe to me, so I wouldn't object -- please add it.

> Please pull my patch, it seems like I can't push to the Yubico repo
> myself.

You should have write access to the project now, we just forgot to bring
over the commit bits when we moved to github. Test them by fixing the
above. :-)

Thanks again,
/Simon

Reply all
Reply to author
Forward
0 new messages