Issue 18 in yatspec: Code review request

[yat...@googlecode.com]

Status: New
Owner: team.son...@gmail.com
CC: spmil...@gmail.com, tim.wool...@gmail.com, daniel...@gmail.com
Labels: Type-Review Priority-Medium

New issue 18 by team.son...@gmail.com: Code review request
https://code.google.com/p/yatspec/issues/detail?id=18

Purpose of code changes on this branch:
Adding a new feature, (yatspec test results can be now collapsible)

When reviewing my code changes, please focus on:
changes made to templates, jquery usage

After the review, I'll merge this branch into:
/trunk

or what's the correct branch to merge into?

How does these changes will get built?

Thanks in advance.
Jon & Sam


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[yat...@googlecode.com]

Comment #1 on issue 18 by team.son...@gmail.com: Code review request
https://code.google.com/p/yatspec/issues/detail?id=18

Please refer to commit 2ddca19b98e1

[yat...@googlecode.com]

Comment #2 on issue 18 by daniel...@gmail.com: Code review request
https://code.google.com/p/yatspec/issues/detail?id=18

Looks good.

Using Google Code online diff for the html it looks like quite a big change

https://code.google.com/p/yatspec/source/diff?spec=svn2ddca19b98e1e06be0a63238f36c634f81318771&r=2ddca19b98e1e06be0a63238f36c634f81318771&format=side&path=/src/com/googlecode/yatspec/rendering/html/yatspec.st

I'm assuming it's just a lot of whitespace changes with a small change
somewhere in there?

[yat...@googlecode.com]

Comment #3 on issue 18 by team.son...@gmail.com: Code review request
https://code.google.com/p/yatspec/issues/detail?id=18

yeah looks like formatting has been changed :( we modified only lines 36-39.

[yat...@googlecode.com]

Updates:
Status: Done

Comment #4 on issue 18 by daniel...@gmail.com: Code review request
https://code.google.com/p/yatspec/issues/detail?id=18

(No comment was entered for this change.)