SpecRunner refactor

5 views
Skip to first unread message

Matt Savage

unread,
Dec 18, 2011, 8:32:39 PM12/18/11
to yat...@googlegroups.com
Hi folks,

Can you take a look at this fork which makes some breaking changes but cleans up the code a fair bit:
There's an explanation of what's in there in the home page for the repo.

If we can reach general agreement, I'd like to move these changes into master.

Cheers,

Matt

Matt Savage

unread,
Dec 19, 2011, 2:44:12 AM12/19/11
to yat...@googlegroups.com
Note to self: we need to remember to update this page if this gets pushed: http://code.google.com/p/yatspec/wiki/Configuration

Daniel Worthington-Bodart

unread,
Dec 19, 2011, 3:29:03 AM12/19/11
to yat...@googlegroups.com
Hey Matt, these changes look great. 

One change I think we will need to bring back is supporting some way to configure listeners without doing it in code. Maybe another factory etc.

Other people:
It would be great if we could get feedback from some of the other teams using Yatspec, the biggest change is around the custom renderers and content header functionality. 

Thanks

Dan

Matt Savage

unread,
Dec 19, 2011, 3:50:37 AM12/19/11
to yat...@googlegroups.com
On 19 December 2011 19:29, Daniel Worthington-Bodart <d...@bodar.com> wrote:
One change I think we will need to bring back is supporting some way to configure listeners without doing it in code. Maybe another factory etc.

Did you see DefaultResultListeners? This uses system properties exactly as SpecRunner did previously.

Does this meet the requirement or do we need more?
 
Other people:
It would be great if we could get feedback from some of the other teams using Yatspec, the biggest change is around the custom renderers and content header functionality. 

+1. I'd really like to be able to start using this. My main requirement is that we need to produce both a tag and normal index, as well as html output.

Daniel Worthington-Bodart

unread,
Dec 19, 2011, 4:52:47 AM12/19/11
to yat...@googlegroups.com

DefaultResultListeners is perfect.sweet!

Steve Smith

unread,
Dec 19, 2011, 6:54:54 AM12/19/11
to yatspec
I've had a look at Matt's fork and it all looks good to me. I really
like the concept of SpecResultListener.

S

On Dec 19, 9:52 am, Daniel Worthington-Bodart <d...@bodar.com> wrote:
> DefaultResultListeners is perfect.sweet!

Matt Savage

unread,
Dec 19, 2011, 5:34:11 PM12/19/11
to yat...@googlegroups.com
Thanks Steve!

Is there anyone representing the Sonique or Halo folks on this list?

Matt Savage

unread,
Dec 21, 2011, 2:39:24 AM12/21/11
to yat...@googlegroups.com
I'm taking lack of objection as consent.

If anyone does have an objection after the event:
  1. Let me know through this list
  2. I'll happily back out my push if you need me to
Cheers,

Matt
Reply all
Reply to author
Forward
0 new messages