[PATCH] [ARM] Make board selection dependent on CONFIG_SMP

[Jean-Christophe Dubois]

Signed-off-by: Jean-Christophe Dubois <j...@tribudubois.net>
---
arch/arm/board/generic/openconf.cfg | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/arm/board/generic/openconf.cfg b/arch/arm/board/generic/openconf.cfg
index d605304..9a44af9 100644
--- a/arch/arm/board/generic/openconf.cfg
+++ b/arch/arm/board/generic/openconf.cfg
@@ -62,7 +62,8 @@ config CONFIG_GENERIC_VEXPRESS

config CONFIG_GENERIC_OMAP3
bool "OMAP3 SOC Support"
- depends on CONFIG_ARMV7A
+ depends on CONFIG_ARMV7A && !CONFIG_SMP
+ default n
select CONFIG_BBFLASH
select CONFIG_OMAP
help
@@ -70,12 +71,12 @@ config CONFIG_GENERIC_OMAP3

config CONFIG_GENERIC_SABRELITE
bool "Freescale Sabrelite Platform"
- depends on CONFIG_ARMV7A
- default y
- select CONFIG_SMP
+ depends on CONFIG_ARMV7A && CONFIG_SMP
+ default n
select CONFIG_ARCH_MXC
select CONFIG_SABRELITE_CONFIG
select CONFIG_COMMON_CLK_MXC
+ select CONFIG_ARM_SMP_IMX
help
This option enables Freescale Sabrelite platform
support for Freescale Sabrelite and
@@ -83,7 +84,8 @@ config CONFIG_GENERIC_SABRELITE

config CONFIG_GENERIC_EXYNOS4
bool "Exynos 4 SOC Support"
- depends on CONFIG_ARMV7A
+ depends on CONFIG_ARMV7A && CONFIG_SMP
+ default n
select CONFIG_EXYNOS
select CONFIG_ARM_GIC
select CONFIG_SAMSUNG_MCT
--
2.7.4

[Anup Patel]

Hi JC,

This patch breaks our aim to support single ARMv7A Xvisor image
for multiple boards.

If we depend OMAP3 on !SMP then OMAP3 support can never
be enabled in Xvisor image for VExpress-A9 and Sabrelite-A9.

Similarly, if we depend Sabrelite on SMP then Sabrelite support
can never be enabled on Xvisor image having SMP disabled.

In general, CONFIG_SMP should always be user selectable
option and it users can willfully disable CONFIG_SMP using
menuconfig if they want.

Regards,
Anup

[Jean-Christophe DUBOIS]

Le 11/07/2016 17:38, Anup Patel a écrit :
> Hi JC,
>
> This patch breaks our aim to support single ARMv7A Xvisor image
> for multiple boards.
>
> If we depend OMAP3 on !SMP then OMAP3 support can never
> be enabled in Xvisor image for VExpress-A9 and Sabrelite-A9.

Yes, I thought about it after sending the patch.

A Cortex A8 image should be more efficient if it has no builtin SMP support.

But we should keep the single image goal.

>
> Similarly, if we depend Sabrelite on SMP then Sabrelite support
> can never be enabled on Xvisor image having SMP disabled.

Sure, after thinking about it, there are some i.MX6 SOC that have only
one core (i.MX6S, i.MX6SX, i.MX6SL)

>
> In general, CONFIG_SMP should always be user selectable
> option and it users can willfully disable CONFIG_SMP using
> menuconfig if they want.

Unless you have seleted a CPU that does not support SMP (ARMv5,
CortexA8, ARM11)
>
> Regards,
> Anup
>