[PATCH 1/8] TESTS: arm32/arm64/riscv: Suppress linker warning

19 views
Skip to first unread message

Anup Patel

unread,
Dec 26, 2022, 9:00:14 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
With latest binutils 2.39 (or higher), we see link time warning
"LOAD segment with RWX permissions". Let us supress this warning.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
tests/common/basic/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/common/basic/Makefile.inc b/tests/common/basic/Makefile.inc
index e98e07eb..ad6eb488 100644
--- a/tests/common/basic/Makefile.inc
+++ b/tests/common/basic/Makefile.inc
@@ -25,7 +25,7 @@ FW_CROSS_COMPILE=$(CROSS_COMPILE)
FW_CPPFLAGS=$(ARCH_CPPFLAGS) -I. -I$(ARCH_BASIC_DIR) -I$(ARCH_DIR)
FW_CFLAGS=$(ARCH_CFLAGS) $(FW_CPPFLAGS) -g -Wall -Werror -nostdlib
FW_ASFLAGS=$(ARCH_ASFLAGS) $(FW_CPPFLAGS) -g -Wall -Werror -nostdlib -D__ASSEMBLY__
-FW_LDFLAGS=$(ARCH_LDFLAGS) $(FW_CFLAGS) -Wl,--build-id=none -Wl,-T$(ARCH_LDSCRIPT)
+FW_LDFLAGS=$(ARCH_LDFLAGS) $(FW_CFLAGS) -Wl,--build-id=none -Wl,--no-warn-rwx-segments -Wl,-T$(ARCH_LDSCRIPT)

ifdef CROSS_COMPILE
CC = $(CROSS_COMPILE)gcc
--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:16 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
This patch cleanup spaces and improves section alignments in basic
firware linker scripts.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
tests/arm32/common/basic/firmware.ld | 108 ++++++++++++++-------------
tests/arm64/common/basic/firmware.ld | 53 +++++++------
tests/riscv/common/basic/firmware.ld | 5 +-
3 files changed, 89 insertions(+), 77 deletions(-)

diff --git a/tests/arm32/common/basic/firmware.ld b/tests/arm32/common/basic/firmware.ld
index 8e8755a1..414d8eba 100755
--- a/tests/arm32/common/basic/firmware.ld
+++ b/tests/arm32/common/basic/firmware.ld
@@ -33,13 +33,15 @@ SECTIONS
PROVIDE(_reloc_region_start = .);

.text :
- {
+ {
*(.expvect)
*(.text)
. = ALIGN(16);
_etext = .;
}

+ . = ALIGN(4096);
+
.data :
{
*(.data)
@@ -47,6 +49,8 @@ SECTIONS
_edata = .;
}

+ . = ALIGN(4096);
+
.rodata :
{
*(.rodata .rodata.*)
@@ -54,7 +58,7 @@ SECTIONS
_erodata = .;
}

- . = ALIGN(16);
+ . = ALIGN(4096);

PROVIDE(_reloc_region_end = .);

@@ -69,66 +73,68 @@ SECTIONS
PROVIDE(_bss_end = .);
}

+ . = ALIGN(4096);
+
.heap :
{
PROVIDE(_heap_start = .);
*(.heap)
- . = . + 8192;
+ . = . + 8192;
. = ALIGN(4);
PROVIDE(_heap_end = .);
}

- . = ALIGN(16);
+ . = ALIGN(4096);

PROVIDE(_zero_region_end = .);

- .svc_stack :
- {
- PROVIDE(_svc_stack_start = .);
- . = . + 4096;
- . = ALIGN(4);
- PROVIDE(_svc_stack_end = .);
- }
-
- .abt_stack :
- {
- PROVIDE(_abt_stack_start = .);
- . = . + 4096;
- . = ALIGN(4);
- PROVIDE(_abt_stack_end = .);
- }
-
- .und_stack :
- {
- PROVIDE(_und_stack_start = .);
- . = . + 4096;
- . = ALIGN(4);
- PROVIDE(_und_stack_end = .);
- }
-
- .irq_stack :
- {
- PROVIDE(_irq_stack_start = .);
- . = . + 4096;
- . = ALIGN(4);
- PROVIDE(_irq_stack_end = .);
- }
-
- .fiq_stack :
- {
- PROVIDE(_fiq_stack_start = .);
- . = . + 4096;
- . = ALIGN(4);
- PROVIDE(_fiq_stack_end = .);
- }
-
- .usr_stack :
- {
- PROVIDE(_usr_stack_start = .);
- . = . + USR_STACK_SIZE ;
- . = ALIGN(4);
- PROVIDE(_usr_stack_end = .);
- }
+ .svc_stack :
+ {
+ PROVIDE(_svc_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(4);
+ PROVIDE(_svc_stack_end = .);
+ }
+
+ .abt_stack :
+ {
+ PROVIDE(_abt_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(4);
+ PROVIDE(_abt_stack_end = .);
+ }
+
+ .und_stack :
+ {
+ PROVIDE(_und_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(4);
+ PROVIDE(_und_stack_end = .);
+ }
+
+ .irq_stack :
+ {
+ PROVIDE(_irq_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(4);
+ PROVIDE(_irq_stack_end = .);
+ }
+
+ .fiq_stack :
+ {
+ PROVIDE(_fiq_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(4);
+ PROVIDE(_fiq_stack_end = .);
+ }
+
+ .usr_stack :
+ {
+ PROVIDE(_usr_stack_start = .);
+ . = . + USR_STACK_SIZE ;
+ . = ALIGN(4);
+ PROVIDE(_usr_stack_end = .);
+ }

PROVIDE(_code_end = .);
}
diff --git a/tests/arm64/common/basic/firmware.ld b/tests/arm64/common/basic/firmware.ld
index 0d09bc01..92eb8f70 100755
--- a/tests/arm64/common/basic/firmware.ld
+++ b/tests/arm64/common/basic/firmware.ld
@@ -33,27 +33,32 @@ SECTIONS
PROVIDE(_reloc_region_start = .);

.text :
- {
+ {
*(.entry)
*(.text)
+ . = ALIGN(8);
_etext = .;
}

+ . = ALIGN(4096);
+
.data :
{
- . = ALIGN(8);
*(.data)
+ . = ALIGN(8);
_edata = .;
}

+ . = ALIGN(4096);
+
.rodata :
{
- . = ALIGN(8);
*(.rodata .rodata.*)
+ . = ALIGN(8);
_erodata = .;
}

- . = ALIGN(8);
+ . = ALIGN(4096);

PROVIDE(_reloc_region_end = .);

@@ -61,41 +66,43 @@ SECTIONS

.bss :
{
- . = ALIGN(8);
PROVIDE(_bss_start = .);
*(.bss)
+ . = ALIGN(8);
_ebss = .;
PROVIDE(_bss_end = .);
}

+ . = ALIGN(4096);
+
.heap :
{
- . = ALIGN(8);
PROVIDE(_heap_start = .);
*(.heap)
- . = . + 4096;
+ . = . + 4096;
+ . = ALIGN(8);
PROVIDE(_heap_end = .);
}

- . = ALIGN(8);
+ . = ALIGN(4096);

PROVIDE(_zero_region_end = .);

- .svc_stack :
- {
- PROVIDE(_svc_stack_start = .);
- . = . + 4096;
- . = ALIGN(8);
- PROVIDE(_svc_stack_end = .);
- }
-
- .usr_stack :
- {
- PROVIDE(_usr_stack_start = .);
- . = . + 4096;
- . = ALIGN(8);
- PROVIDE(_usr_stack_end = .);
- }
+ .svc_stack :
+ {
+ PROVIDE(_svc_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(8);
+ PROVIDE(_svc_stack_end = .);
+ }
+
+ .usr_stack :
+ {
+ PROVIDE(_usr_stack_start = .);
+ . = . + 4096;
+ . = ALIGN(8);
+ PROVIDE(_usr_stack_end = .);
+ }

PROVIDE(_code_end = .);
}
diff --git a/tests/riscv/common/basic/firmware.ld b/tests/riscv/common/basic/firmware.ld
index dd078e23..ce12f92e 100755
--- a/tests/riscv/common/basic/firmware.ld
+++ b/tests/riscv/common/basic/firmware.ld
@@ -35,7 +35,7 @@ SECTIONS
/* Beginning of the code section */

.text :
- {
+ {
PROVIDE(_text_start = .);
*(.entry)
*(.text)
@@ -93,10 +93,9 @@ SECTIONS

.heap :
{
- . = ALIGN(8);
PROVIDE(_heap_start = .);
*(.heap)
- . = . + 4096;
+ . = . + 4096;
PROVIDE(_heap_end = .);
}

--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:18 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
With latest binutils 2.39 (or higher), we see link time warning
"LOAD segment with RWX permissions". Let us supress this warning.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 26fe3d98..80546a2c 100644
--- a/Makefile
+++ b/Makefile
@@ -176,7 +176,7 @@ asflags+=$(cpu-asflags)
asflags+=$(libs-asflags-y)
asflags+=$(cppflags)
arflags=rcs
-ldflags=-g -Wall -nostdlib -Wl,--build-id=none
+ldflags=-g -Wall -nostdlib -Wl,--build-id=none -Wl,--no-warn-rwx-segments
ldflags+=$(board-ldflags)
ldflags+=$(cpu-ldflags)
ldflags+=$(libs-ldflags-y)
--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:22 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
With GCC 12 (or higher), we see compile time warnings in vmm_devtree.c
and vmm_workqueue.c so let us fix these warnings.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
core/vmm_devtree.c | 5 ++---
core/vmm_workqueue.c | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/core/vmm_devtree.c b/core/vmm_devtree.c
index 30119bf2..4ea36b16 100644
--- a/core/vmm_devtree.c
+++ b/core/vmm_devtree.c
@@ -1279,8 +1279,7 @@ const struct vmm_devtree_nodeid *vmm_devtree_match_node(
while (matches->name[0] || matches->type[0] || matches->compatible[0]) {
int match = 1;
if (matches->name[0])
- match &= node->name &&
- !strcmp(matches->name, node->name);
+ match &= !strcmp(matches->name, node->name);
if (matches->type[0])
match &= type && !strcmp(matches->type, type);
if (matches->compatible[0])
@@ -1736,7 +1735,7 @@ struct vmm_devtree_node *vmm_devtree_get_child_by_name(
struct vmm_devtree_node *ret = NULL, *child = NULL;

vmm_devtree_for_each_child(child, node) {
- if (child->name && (strcasecmp(child->name, name) == 0)) {
+ if (strcasecmp(child->name, name) == 0) {
ret = child;
break;
}
diff --git a/core/vmm_workqueue.c b/core/vmm_workqueue.c
index 26575869..4a411e6a 100644
--- a/core/vmm_workqueue.c
+++ b/core/vmm_workqueue.c
@@ -423,7 +423,7 @@ static int workqueue_startup(struct vmm_cpuhp_notify *cpuhp, u32 cpu)
vmm_snprintf(syswq_name, sizeof(syswq_name), "syswq/%d", cpu);
wqctrl.syswq[cpu] = vmm_workqueue_create(syswq_name,
VMM_THREAD_DEF_PRIORITY);
- if (!wqctrl.syswq) {
+ if (!wqctrl.syswq[cpu]) {
return VMM_EFAIL;
}

--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:30 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
The mmu_pgtbl_attach() called by mmu_pgtbl_get_child() might fail
if more than one host CPUs try to attach a child page table for the
same map_ia so we should print error in mmu_pgtbl_get_child() only
when mmu_pgtbl_attach() fails due to some other reason.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
arch/common/generic_mmu.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/common/generic_mmu.c b/arch/common/generic_mmu.c
index 519cd46b..13e7f6af 100644
--- a/arch/common/generic_mmu.c
+++ b/arch/common/generic_mmu.c
@@ -334,7 +334,7 @@ static int mmu_pgtbl_attach(struct mmu_pgtbl *parent,

if (arch_mmu_pte_is_valid(&pte[index], parent->stage, parent->level)) {
vmm_spin_unlock_irqrestore_lite(&parent->tbl_lock, flags);
- return VMM_EFAIL;
+ return VMM_EEXIST;
}

arch_mmu_pte_set_table(&pte[index], parent->stage, parent->level,
@@ -526,11 +526,13 @@ struct mmu_pgtbl *mmu_pgtbl_get_child(struct mmu_pgtbl *parent,
}

if ((rc = mmu_pgtbl_attach(parent, map_ia, child))) {
- vmm_printf("%s: failed to attach child for address "
- "0x%"PRIPADDR" in page table at "
- "0x%"PRIPADDR" stage=%d level=%d\n",
- __func__, map_ia, parent->tbl_pa,
- parent->stage, parent->level);
+ if (rc != VMM_EEXIST) {
+ vmm_printf("%s: failed to attach child for address "
+ "0x%"PRIPADDR" in page table at "
+ "0x%"PRIPADDR" stage=%d level=%d\n",
+ __func__, map_ia, parent->tbl_pa,
+ parent->stage, parent->level);
+ }
mmu_pgtbl_free(child);
child = NULL;
}
--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:33 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
The latest GCC 12 (or higher) does not auto-convert "inline"
function into "static inline" function which leads to compile
errors hence this patch fixes related compile errors in mouse
driver headers.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
drivers/input/mouse/alps.h | 4 ++--
drivers/input/mouse/lifebook.h | 6 +++---
drivers/input/mouse/logips2pp.h | 2 +-
drivers/input/mouse/sentelic.h | 4 ++--
drivers/input/mouse/trackpoint.h | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h
index ae1ac354..acc1e89e 100644
--- a/drivers/input/mouse/alps.h
+++ b/drivers/input/mouse/alps.h
@@ -51,11 +51,11 @@ struct alps_data {
int alps_detect(struct psmouse *psmouse, bool set_properties);
int alps_init(struct psmouse *psmouse);
#else
-inline int alps_detect(struct psmouse *psmouse, bool set_properties)
+static inline int alps_detect(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
-inline int alps_init(struct psmouse *psmouse)
+static inline int alps_init(struct psmouse *psmouse)
{
return -ENOSYS;
}
diff --git a/drivers/input/mouse/lifebook.h b/drivers/input/mouse/lifebook.h
index 4c4326c6..0baf02a7 100644
--- a/drivers/input/mouse/lifebook.h
+++ b/drivers/input/mouse/lifebook.h
@@ -16,14 +16,14 @@ void lifebook_module_init(void);
int lifebook_detect(struct psmouse *psmouse, bool set_properties);
int lifebook_init(struct psmouse *psmouse);
#else
-inline void lifebook_module_init(void)
+static inline void lifebook_module_init(void)
{
}
-inline int lifebook_detect(struct psmouse *psmouse, bool set_properties)
+static inline int lifebook_detect(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
-inline int lifebook_init(struct psmouse *psmouse)
+static inline int lifebook_init(struct psmouse *psmouse)
{
return -ENOSYS;
}
diff --git a/drivers/input/mouse/logips2pp.h b/drivers/input/mouse/logips2pp.h
index 0c186f02..439e9c58 100644
--- a/drivers/input/mouse/logips2pp.h
+++ b/drivers/input/mouse/logips2pp.h
@@ -14,7 +14,7 @@
#ifdef CONFIG_MOUSE_PS2_LOGIPS2PP
int ps2pp_init(struct psmouse *psmouse, bool set_properties);
#else
-inline int ps2pp_init(struct psmouse *psmouse, bool set_properties)
+static inline int ps2pp_init(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
diff --git a/drivers/input/mouse/sentelic.h b/drivers/input/mouse/sentelic.h
index aa697ece..42df9e3b 100644
--- a/drivers/input/mouse/sentelic.h
+++ b/drivers/input/mouse/sentelic.h
@@ -123,11 +123,11 @@ struct fsp_data {
extern int fsp_detect(struct psmouse *psmouse, bool set_properties);
extern int fsp_init(struct psmouse *psmouse);
#else
-inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
+static inline int fsp_detect(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
-inline int fsp_init(struct psmouse *psmouse)
+static inline int fsp_init(struct psmouse *psmouse)
{
return -ENOSYS;
}
diff --git a/drivers/input/mouse/trackpoint.h b/drivers/input/mouse/trackpoint.h
index e558a709..f14e59c0 100644
--- a/drivers/input/mouse/trackpoint.h
+++ b/drivers/input/mouse/trackpoint.h
@@ -145,7 +145,7 @@ struct trackpoint_data
#ifdef CONFIG_MOUSE_PS2_TRACKPOINT
int trackpoint_detect(struct psmouse *psmouse, bool set_properties);
#else
-inline int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
+static inline int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
{
return -ENOSYS;
}
--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:33 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
Use latest linux version in the release tarball scripts.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
tests/common/scripts/build-arm-images.sh | 2 +-
tests/common/scripts/build-images.sh | 2 +-
tests/common/scripts/build-riscv-images.sh | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/common/scripts/build-arm-images.sh b/tests/common/scripts/build-arm-images.sh
index 5e7969d8..aa2c7ceb 100755
--- a/tests/common/scripts/build-arm-images.sh
+++ b/tests/common/scripts/build-arm-images.sh
@@ -42,7 +42,7 @@ BUILD_XVISOR_ONLY="no"
BUILD_XVISOR_OUTPUT_PATH=`pwd`/build/xvisor
BUILD_TARBALL_PATH=`pwd`/tarball
BUILD_GUEST_OUTPUT_PATH=`pwd`/build/guest
-BUILD_LINUX_VERSION="5.15.3"
+BUILD_LINUX_VERSION="6.1.1"
BUILD_BUSYBOX_VERSION="1.33.1"
BUILD_PRINT_CONFIG_ONLY="no"

diff --git a/tests/common/scripts/build-images.sh b/tests/common/scripts/build-images.sh
index 02d38353..ebf8bcb1 100755
--- a/tests/common/scripts/build-images.sh
+++ b/tests/common/scripts/build-images.sh
@@ -22,7 +22,7 @@ BUILD_OUTPUT_PATH=`pwd`/build
BUILD_INSTALL_PATH=`pwd`/install
BUILD_XVISOR_SOURCE_PATH=`pwd`
BUILD_TARBALL_PATH=`pwd`/tarball
-BUILD_LINUX_VERSION="5.15.3"
+BUILD_LINUX_VERSION="6.1.1"
BUILD_BUSYBOX_VERSION="1.33.1"

while getopts "d:hj:l:i:o:p:" o; do
diff --git a/tests/common/scripts/build-riscv-images.sh b/tests/common/scripts/build-riscv-images.sh
index c99c2152..4e82068e 100755
--- a/tests/common/scripts/build-riscv-images.sh
+++ b/tests/common/scripts/build-riscv-images.sh
@@ -41,7 +41,7 @@ BUILD_XVISOR_ONLY="no"
BUILD_XVISOR_OUTPUT_PATH=`pwd`/build/xvisor
BUILD_TARBALL_PATH=`pwd`/tarball
BUILD_GUEST_OUTPUT_PATH=`pwd`/build/guest
-BUILD_LINUX_VERSION="5.15.3"
+BUILD_LINUX_VERSION="6.1.1"
BUILD_BUSYBOX_VERSION="1.33.1"
BUILD_PRINT_CONFIG_ONLY="no"

--
2.34.1

Anup Patel

unread,
Dec 26, 2022, 9:00:49 AM12/26/22
to xvisor...@googlegroups.com, Anup Patel
The latest binutils 2.39 throw a linker warning
"missing .note.GNU-stack section implies executable stack"
when compiling for ARM32-ve.

This patch fixes the above linker warning.

Signed-off-by: Anup Patel <apa...@ventanamicro.com>
---
arch/arm/cpu/arm32ve/objects.mk | 3 ++-
tests/arm32/common/basic/Makefile.inc | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/arm32ve/objects.mk b/arch/arm/cpu/arm32ve/objects.mk
index 42429cb1..f5bcffb7 100644
--- a/arch/arm/cpu/arm32ve/objects.mk
+++ b/arch/arm/cpu/arm32ve/objects.mk
@@ -41,7 +41,8 @@ ifeq ($(CONFIG_ARM32VE_STACKTRACE), y)
cpu-cflags += -fno-omit-frame-pointer -mapcs -mno-sched-prolog
endif
cpu-asflags += -marm $(arch-y) $(tune-y)
-cpu-ldflags += -msoft-float
+cpu-ldflags += -msoft-float -z noexecstack
+cpu-mergeflags += -z noexecstack

cpu-objs-y+= cpu_entry.o
cpu-objs-y+= cpu_proc.o
diff --git a/tests/arm32/common/basic/Makefile.inc b/tests/arm32/common/basic/Makefile.inc
index 116b5f89..96033118 100644
--- a/tests/arm32/common/basic/Makefile.inc
+++ b/tests/arm32/common/basic/Makefile.inc
@@ -34,7 +34,7 @@ ARCH_CPPFLAGS+=-DTEXT_START=$(board_text_start) -DUSR_STACK_SIZE=$(board_usr_sta
ARCH_CFLAGS=$(board_cflags) -msoft-float -marm
ARCH_ASFLAGS=$(board_asflags) -msoft-float -marm
ARCH_LDSCRIPT=$(obj_dir)/firmware.lnk
-ARCH_LDFLAGS=$(board_ldflags)
+ARCH_LDFLAGS=-z noexecstack $(board_ldflags)

ifeq ($(board_arch),v5)
ARCH_CPPFLAGS+=-DARM_ARCH_v5
--
2.34.1

Anup Patel

unread,
Dec 27, 2022, 10:53:08 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> With latest binutils 2.39 (or higher), we see link time warning
> "LOAD segment with RWX permissions". Let us supress this warning.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> ---
> tests/common/basic/Makefile.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/common/basic/Makefile.inc b/tests/common/basic/Makefile.inc
> index e98e07eb..ad6eb488 100644
> --- a/tests/common/basic/Makefile.inc
> +++ b/tests/common/basic/Makefile.inc
> @@ -25,7 +25,7 @@ FW_CROSS_COMPILE=$(CROSS_COMPILE)
> FW_CPPFLAGS=$(ARCH_CPPFLAGS) -I. -I$(ARCH_BASIC_DIR) -I$(ARCH_DIR)
> FW_CFLAGS=$(ARCH_CFLAGS) $(FW_CPPFLAGS) -g -Wall -Werror -nostdlib
> FW_ASFLAGS=$(ARCH_ASFLAGS) $(FW_CPPFLAGS) -g -Wall -Werror -nostdlib -D__ASSEMBLY__
> -FW_LDFLAGS=$(ARCH_LDFLAGS) $(FW_CFLAGS) -Wl,--build-id=none -Wl,-T$(ARCH_LDSCRIPT)
> +FW_LDFLAGS=$(ARCH_LDFLAGS) $(FW_CFLAGS) -Wl,--build-id=none -Wl,--no-warn-rwx-segments -Wl,-T$(ARCH_LDSCRIPT)
>
> ifdef CROSS_COMPILE
> CC = $(CROSS_COMPILE)gcc
> --
> 2.34.1
>
> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-1-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:00:12 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> This patch cleanup spaces and improves section alignments in basic
> firware linker scripts.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-2-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:00:26 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> With latest binutils 2.39 (or higher), we see link time warning
> "LOAD segment with RWX permissions". Let us supress this warning.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 26fe3d98..80546a2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -176,7 +176,7 @@ asflags+=$(cpu-asflags)
> asflags+=$(libs-asflags-y)
> asflags+=$(cppflags)
> arflags=rcs
> -ldflags=-g -Wall -nostdlib -Wl,--build-id=none
> +ldflags=-g -Wall -nostdlib -Wl,--build-id=none -Wl,--no-warn-rwx-segments
> ldflags+=$(board-ldflags)
> ldflags+=$(cpu-ldflags)
> ldflags+=$(libs-ldflags-y)
> --
> 2.34.1
>
> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-3-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:00:45 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> With GCC 12 (or higher), we see compile time warnings in vmm_devtree.c
> and vmm_workqueue.c so let us fix these warnings.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-4-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:01:04 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> The latest GCC 12 (or higher) does not auto-convert "inline"
> function into "static inline" function which leads to compile
> errors hence this patch fixes related compile errors in mouse
> driver headers.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-5-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:01:20 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> The latest binutils 2.39 throw a linker warning
> "missing .note.GNU-stack section implies executable stack"
> when compiling for ARM32-ve.
>
> This patch fixes the above linker warning.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-6-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:01:33 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> The mmu_pgtbl_attach() called by mmu_pgtbl_get_child() might fail
> if more than one host CPUs try to attach a child page table for the
> same map_ia so we should print error in mmu_pgtbl_get_child() only
> when mmu_pgtbl_attach() fails due to some other reason.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-7-apatel%40ventanamicro.com.

Anup Patel

unread,
Dec 27, 2022, 11:01:51 PM12/27/22
to xvisor...@googlegroups.com, Anup Patel
On Mon, Dec 26, 2022 at 7:30 PM Anup Patel <apa...@ventanamicro.com> wrote:
>
> Use latest linux version in the release tarball scripts.
>
> Signed-off-by: Anup Patel <apa...@ventanamicro.com>

Applied this patch to xvisor-next repo.

Thanks,
Anup

> --
> You received this message because you are subscribed to the Google Groups "Xvisor Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to xvisor-devel...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/xvisor-devel/20221226140002.276072-8-apatel%40ventanamicro.com.
Reply all
Reply to author
Forward
0 new messages