Exit OHIF viewer

Lindy Zhu

unread,

Dec 6, 2019, 2:47:17 PM12/6/19

to xnat_discussion

Hello there,

My team is concerned about how to exit the OHIF viewer. The only way we discovered is to click the back button on the web browser. Is there any other way in the XNAT system to exit the viewer?

Thanks in advance,

Lindy

Daniel Marcus

unread,

Dec 6, 2019, 5:34:25 PM12/6/19

to xnat_di...@googlegroups.com

Hi Lindy,

You are correct and this bothers me too. My personal workaround is to right click the View Images link to open it in another browser tab.

Some not unrelated news... the OHIF semi-officially released OHIF 2.0 at RSNA this week. I anticipate that we'll move rapidly toward adopting it in XNAT and will address Lindy's concern along the way. I was really impressed with the new code and features in OHIF 2.0 - not surprisingly, the OHIF team has done an outstanding job. Stay tuned for updates coming soon.

-Dan

--
You received this message because you are subscribed to the Google Groups "xnat_discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to xnat_discussi...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/xnat_discussion/5c09b554-48fb-45ae-ae0c-bb5def002ca4%40googlegroups.com.

Simon Doran

unread,

Dec 6, 2019, 7:45:15 PM12/6/19

to xnat_discussion

Hi Lindy and Dan,

When we initially integrated the OHIF viewer into XNAT, we did it in the same way as for the legacy XImgView, which was to put the viewer into an iFrame, with a close button. I think that this is still the way Dan would like it. However, when we introduced the "viewer in a new page" version people in our lab liked it much more and definitely prefer the way it is now.

We definitely recognise that needing to click on "back" in the browser could, under certain circumstances be problematic. However, are there actually any disadvantages to opening in a new tab? Is that right-click really so awkward? In my view, this has a significant advantage in that, if you want, you can open the viewer in a new browser window so that you can see the session page and the viewer at the same time, which is not really possible in the iFrame version. I think it would be a regressive change to revert to that.

Other viewpoints welcome :-)

On Dan's other point, we're planning to do the OHIF 2.0 integration in about February, after NAMIC project week, when there might be more developments, and once the new React-based version is stable.

Best wishes,

Simon

Florida, Mark

unread,

Dec 6, 2019, 9:37:44 PM12/6/19

to xnat_di...@googlegroups.com

Modifying the viewer code so it opens in a new tab/window would be trivial and would allow the viewer to be independent of the page that opens it.

- Mark

--
You received this message because you are subscribed to the Google Groups "xnat_discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to xnat_discussi...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/xnat_discussion/a9a491d7-9e47-48b1-a2dd-4c21a2b94904%40googlegroups.com.

The materials in this message are private and may contain Protected Healthcare Information or other information of a sensitive nature. If you are not the intended recipient, be advised that any unauthorized use, disclosure, copying or the taking of any action in reliance on the contents of this information is strictly prohibited. If you have received this email in error, please immediately notify the sender via telephone or return mail.

Simon Doran

unread,

Dec 7, 2019, 1:34:31 PM12/7/19

to xnat_discussion

Mark,

This is what it does now. I was saying that I did not think reverting back to the iFrame approach was a good thing to do, but it might be worth introducing the ability for this behaviour to be customisable.

As a general point, where are we with the whole question of user preferences in XNAT?

Best wishes,

Simon

Lindy Zhu

unread,

Dec 9, 2019, 11:10:08 AM12/9/19

to xnat_discussion

Hello everyone,

Thank you for your help. I have tried to right-click "View Session", however, it seems no different from left-clicking at my end. I didn't see a popup window to select "open in a new tab. Do we need to modify any code?

Best regards,

Lindy

Simon Doran

unread,

Dec 10, 2019, 3:47:29 AM12/10/19

to xnat_discussion

Hi Lindy,

Here's a movie of the behaviour for my Mac with the XNAT-OHIF viewer version 2.0.0. The black circles that appear represent mouse left-clicks and the green circle is a right-click.

On Safari, Chrome and Firefox, left-click puts the viewer in the same window, whilst right-click puts it in a new tab. It's possible that your browser may require permission to pop up this new tab. (Apologies, I slightly misremembered this behaviour inasmuch as right-click doesn't give you a context menu to choose between new tab and new window, which was what I had thought it did.)