May I change the hasRoster method to be a public method and run on the other queue ?

9 views
Skip to first unread message

niu niushuiniu1999

unread,
Feb 10, 2012, 9:09:59 PM2/10/12
to XMPPFramework
I don't understand the reason to limit the hasRoster method that only
can be invoked on the moduleQueue. Can I ignore this limit?
-(void)hasRoster
{
NSAssert(dispatch_get_current_queue() == moduleQueue,@"Invoked on
incorrect queue");
return (flag & kHasRoster) ? YES : NO;
}

Robbie Hanson

unread,
Feb 16, 2012, 8:42:27 PM2/16/12
to xmppfr...@googlegroups.com
You're correct. There's no reason this method can't be made public. The only reason it's not… is cause I didn't think anybody would need it. I was clearly wrong. If you'd like, send over a patch and I'll apply it to the public repository for you.

-Robbie Hanson

P.S. - Don't forget to check current dispatch queue, and if needed, dispatch_sync to the moduleQueue.

> --
> You received this message because you are subscribed to the Google Groups "XMPPFramework" group.
> To post to this group, send email to xmppfr...@googlegroups.com.
> To unsubscribe from this group, send email to xmppframewor...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/xmppframework?hl=en.
>

Reply all
Reply to author
Forward
0 new messages