Why "nokogiri ~> 1.4.0"?

[Thibaut Barrère]

Hello!

I have an app that is already working with Nokogiri 1.5.0 and we're adding Blather to it.

Is this version of Nokogiri incompatible with Blather, or is it just a matter of updating the gemspec?

(for now we are downgrading the app to Nokogiri 1.4.7)

Thanks!

-- Thibaut

[Ben Langfeld]

There were a lot of issues with 1.5.0, especially on JRuby. I will
check in the next few days if recent patch releases have addressed the
issues sufficiently.

Regards,
Ben Langfeld

> --
> You received this message because you are subscribed to the Google Groups
> "Blather" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/xmpp-blather/-/a08FEc5xVbcJ.
> To post to this group, send email to xmpp-b...@googlegroups.com.
> To unsubscribe from this group, send email to
> xmpp-blather...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/xmpp-blather?hl=en.

[Thibaut Barrère]

Hi Ben,

 

There were a lot of issues with 1.5.0, especially on JRuby. I will
check in the next few days if recent patch releases have addressed the
issues sufficiently.

Thanks for the quick feedback, appreciated! (This app is on REE 1.8.7, FWIW).

Just curious: how do you check? Is running the test suite enough to figure out if we can mostly upgrade on a specific install, or are there more complicated things to do?

-- Thibaut

[Ben Langfeld]

Just the test suite. If you can do a full run against all supported
ruby versions and report any issues, that would speed things up :)

Regards,
Ben Langfeld

[Thibaut Barrère]

Just the test suite. If you can do a full run against all supported
ruby versions and report any issues, that would speed things up :)

The machine I have today doesn't have many versions of Ruby so I will just try a couple and report back.

That said I'll be able to do more extensive tests this week-end if you'd like!

-- Thibaut

[Thibaut Barrère]

Foreword: I did all my tweaking based on v0.6.2 because I got plenty of exceptions on master (like http://travis-ci.org/#!/sprsquish/blather/jobs/792819). I used ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin11.2.0], MBARI 0x6770, Ruby Enterprise Edition 2011.03 here to get started.

Are the tests on v0.6.2 already significant enough?

I forked both blather (and branched from stable v0.6.2) and niceogiri to relax the nokogiri version contraint

https://github.com/thbar/blather/compare/0.6.2.1

https://github.com/thbar/niceogiri/compare/master

then I tested three scenarios:

1/ gemfile unmodified:

=> 866 tests, 2015 assertions, 0 failures, 0 errors, 0 skips

2/ gemfile modified:

  gem 'niceogiri', :git => 'https://github.com/thbar/niceogiri.git'

  gem 'nokogiri', '1.5.0'

=> 1 failure => https://gist.github.com/1978739

3/ gemfile modified:

  gem 'niceogiri', :git => 'https://github.com/thbar/niceogiri.git'

  gem 'nokogiri', '1.5.1.rc1'

=> 866 tests, 2015 assertions, 0 failures, 0 errors, 0 skips

So it looks like things work properly on 1.8.7 with 1.5.1.rc1!

I wonder:

- if it wouldn't be worthwhile to use the Travis matrix like I did here to cross-test on various Nokogiri versions? (so you wouldn't have to think too much about it?)

- if all this is meaningful at all or not, given that the test suite doesn't pass on master (maybe plenty of extra tests which would already fail on 0.6.2?)

Let me know what you think!

-- Thibaut

[Ben Langfeld]

The stuff on the develop branch is failing because I've been doing
some major refactoring. I expected to have this complete sooner, hence
putting it there rather than a feature branch. Turns out that was a
fail. I'll get that passing soon.

As for different versions of nokogiri, that sounds good. I'd *love* a
pull request :)

Lastly, yes, it looks like 1.5.1 will be good, and the failure on
1.5.0 is this: https://github.com/sprsquish/blather/issues/55

I need to take a look at where we're up to on JRuby before I can bump
the dependency with confidence. We may very well still have to wait
for 1.5.1 (which seems to be taking *forever*).

Regards,
Ben Langfeld

[Thibaut Barrère]

As for different versions of nokogiri, that sounds good. I'd *love* a
pull request :)

My pleasure: I'll work on that this week-end!

 

Lastly, yes, it looks like 1.5.1 will be good, and the failure on
1.5.0 is this: https://github.com/sprsquish/blather/issues/55

I need to take a look at where we're up to on JRuby before I can bump
the dependency with confidence. We may very well still have to wait
for 1.5.1 (which seems to be taking *forever*).

Sure - thanks a lot for the input, appreciated!

-- Thibaut

[Thibaut Barrère]

Hi Ben et al,

here it is:

https://github.com/sprsquish/blather/pull/84

-- Thibaut

[Thibaut Barrère]

Update on something related: Nokogiri 1.5.1 *and* 1.5.2 are now out :)

It seems (but I haven't rebased) that blather pass tests, here on my fork:

http://travis-ci.org/#!/thbar/blather

I will work on a pull-request to provide the test matrix on develop.

hope this helps :)

-- Thibaut