Issue 84 in xar: Crash on xar_close

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 84 by dev.iceb...@gmail.com: Crash on xar_close
http://code.google.com/p/xar/issues/detail?id=84

What steps will reproduce the problem?

When invoking xar_close in one case, it results in a crash in libz:

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000104a00000
Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Thread 0 Crashed: Dispatch queue: com.apple.main-thread
0 libz.1.dylib 0x00007fff80003e3a adler32 + 274
1 libz.1.dylib 0x00007fff800053ab deflateInit_ + 366
2 libz.1.dylib 0x00007fff80005682 deflateSetDictionary
+ 532
3 libz.1.dylib 0x00007fff80006915 deflate + 2205
4 libxar.1.dylib 0x00007fff83e9dd82 xar_close + 1146

Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x00000000023c9fc9 rbx: 0x00000000000076b2 rcx:
0x0000000104a00000 rdx: 0x00000000000076b2
rdi: 0x00000000000076b2 rsi: 0x00000000000076b2 rbp:
0x00007fff5fbff300 rsp: 0x00007fff5fbff2d8
r8: 0x00000000000076b2 r9: 0x00000000000076b2 r10:
0x00000000000076b2 r11: 0x00000000000076b2
r12: 0x00000000000076b2 r13: 0x00000000000076b2 r14:
0x00000000000076b2 r15: 0x00000000000076b2
rip: 0x00007fff80003e3a rfl: 0x0000000000010206 cr2: 0x0000000104a00000

I still need to investigate this further as this is the first time I see
this in 3 years.

What is the expected output?

A xar file

What do you see instead?

A crash

What version of the product are you using? On what operating system?

1.5.2 Mac OS X 10.6.8

[codesite...@google.com]

Comment #1 on issue 84 by dev.iceb...@gmail.com: Crash on xar_close
http://code.google.com/p/xar/issues/detail?id=84

As far as I can tell, this is related to not having enough free space on
the disk.

IMHO, xar_close should not crash but returns an error.