[PATCH v2][RFC] Beagle Rev C5 support

24 views
Skip to first unread message

Koen Kooi

unread,
Jun 7, 2011, 4:09:24 PM6/7/11
to x-lo...@googlegroups.com, beagl...@googlegroups.com, Joel Fernandes, Joel A Fernandes, Koen Kooi
From: Joel Fernandes <agnel...@gmail.com>

This patch adds Rev C5 support for a new memory chip that was added to
the Beagleboard Revision C5. The chip is 256MB SDRAM and the following
patch enables it.

The micron memory chip part is: MT29C4G48MAZAPAKQ-5 IT.

Signed-off-by: Joel A Fernandes <joel...@ti.com>
Signed-off-by: Koen Kooi <k-k...@ti.com>
---

I have tested my patch and it works fine but before I submit it, I
will be grateful if I can get some review feedback (specially with the
details of timing and AC parameter values). Thanks

Changes since v1:
* removed mailer whitespace damage - Koen

board/omap3530beagle/omap3530beagle.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/board/omap3530beagle/omap3530beagle.c b/board/omap3530beagle/omap3530beagle.c
index 15943f5..2b8c3c0 100644
--- a/board/omap3530beagle/omap3530beagle.c
+++ b/board/omap3530beagle/omap3530beagle.c
@@ -281,6 +281,7 @@ u32 wait_on_value(u32 read_bit_mask, u32 match_value, u32 read_addr, u32 bound)

#define MICRON_DDR 0
#define NUMONYX_MCP 1
+#define MICRON_MCP 2
int identify_xm_ddr()
{
int mfr, id;
@@ -303,6 +304,8 @@ int identify_xm_ddr()
return MICRON_DDR;
if ((mfr == 0x20) && (id == 0xba))
return NUMONYX_MCP;
+ if ((mfr == 0x2c) && (id == 0xbc))
+ return MICRON_MCP;
}
/*********************************************************************
* config_3430sdram_ddr() - Init DDR on 3430SDP dev board.
@@ -329,6 +332,17 @@ void config_3430sdram_ddr(void)
__raw_writel(NUMONYX_V_ACTIMB_165, SDRC_ACTIM_CTRLB_1);
__raw_writel(SDP_3430_SDRC_RFR_CTRL_165MHz, SDRC_RFR_CTRL_0);
__raw_writel(SDP_3430_SDRC_RFR_CTRL_165MHz, SDRC_RFR_CTRL_1);
+ } else if (identify_xm_ddr() == MICRON_MCP) {
+ /* Beagleboard Rev C5 */
+ __raw_writel(0x2, SDRC_CS_CFG); /* 256MB/bank */
+ __raw_writel(SDP_SDRC_MDCFG_0_DDR_MICRON_XM, SDRC_MCFG_0);
+ __raw_writel(SDP_SDRC_MDCFG_0_DDR_MICRON_XM, SDRC_MCFG_1);
+ __raw_writel(MICRON_V_ACTIMA_200, SDRC_ACTIM_CTRLA_0);
+ __raw_writel(MICRON_V_ACTIMB_200, SDRC_ACTIM_CTRLB_0);
+ __raw_writel(MICRON_V_ACTIMA_200, SDRC_ACTIM_CTRLA_1);
+ __raw_writel(MICRON_V_ACTIMB_200, SDRC_ACTIM_CTRLB_1);
+ __raw_writel(SDP_3430_SDRC_RFR_CTRL_200MHz, SDRC_RFR_CTRL_0);
+ __raw_writel(SDP_3430_SDRC_RFR_CTRL_200MHz, SDRC_RFR_CTRL_1);
} else {
__raw_writel(0x1, SDRC_CS_CFG); /* 128MB/bank */
__raw_writel(SDP_SDRC_MDCFG_0_DDR, SDRC_MCFG_0);
@@ -699,6 +713,8 @@ int misc_init_r(void)
case REVISION_C4:
if (identify_xm_ddr() == NUMONYX_MCP)
printf("Beagle Rev C4 from Special Computing\n");
+ else if(identify_xm_ddr() == MICRON_MCP)
+ printf("Beagle Rev C5\n");
else
printf("Beagle Rev C4\n");
break;
--
1.6.6.1

Jason Kridner

unread,
Jun 18, 2011, 12:02:52 AM6/18/11
to x-lo...@googlegroups.com, beagl...@googlegroups.com, Joel Fernandes, Joel A Fernandes, Koen Kooi
On Tue, Jun 7, 2011 at 4:09 PM, Koen Kooi <ko...@dominion.thruhere.net> wrote:
> From: Joel Fernandes <agnel...@gmail.com>
>
> This patch adds Rev C5 support for a new memory chip that was added to
> the Beagleboard Revision C5. The chip is 256MB SDRAM and the following
> patch enables it.
>
> The micron memory chip part is: MT29C4G48MAZAPAKQ-5 IT.
>
> Signed-off-by: Joel A Fernandes <joel...@ti.com>
> Signed-off-by: Koen Kooi <k-k...@ti.com>

Acked-by: Jason Kridner <jkri...@beagleboard.org>

It seems to be working fine for me.

> --
> --
> To unsubscribe from this group, email: x-loader+u...@googlegroups.com
> For more options: http://groups.google.com/group/x-loader?hl=en?hl=en
> Home Page: http://gitorious.org/x-loader
>

Gadiyar, Anand

unread,
Jul 15, 2011, 2:11:36 AM7/15/11
to x-lo...@googlegroups.com, beagl...@googlegroups.com, Joel Fernandes, Fernandes, Joel A, Kooi, Koen, jkri...@beagleboard.org
Koen Kooi wrote:
> Sent: Wednesday, June 08, 2011 1:39 AM
> To: x-lo...@googlegroups.com; beagl...@googlegroups.com
> Cc: Joel Fernandes; Fernandes, Joel A; Kooi, Koen
> Subject: [x-loader] [PATCH v2][RFC] Beagle Rev C5 support

>
> From: Joel Fernandes <agnel...@gmail.com>
>
> This patch adds Rev C5 support for a new memory chip that was added to
> the Beagleboard Revision C5. The chip is 256MB SDRAM and the following
> patch enables it.
>
> The micron memory chip part is: MT29C4G48MAZAPAKQ-5 IT.
>
> Signed-off-by: Joel A Fernandes <joel...@ti.com>
> Signed-off-by: Koen Kooi <k-k...@ti.com>

Applied now and pushed out, thanks!

Jason, I missed adding your ack when merging this patch - just
noticed it now. Will be more careful in future.

- Anand

Reply all
Reply to author
Forward
0 new messages