The fix is already applied for overo, as you can see from commit
24b8b7f41a83540433024854736518876257672c, changing the index calculation
to behave correctly with all board revs. This patch only applies the
same fix for the other omap 3 based boards that could be affected.
BugLink: https://bugs.launchpad.net/ubuntu/+source/x-loader/+bug/813407
Signed-off-by: Ricardo Salveti de Araujo <ricardo...@linaro.org>
---
board/igep00x0/igep00x0.c | 2 +-
board/omap3530beagle/omap3530beagle.c | 2 +-
board/omap3evm/omap3evm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/board/igep00x0/igep00x0.c b/board/igep00x0/igep00x0.c
index 5550741..d880b48 100644
--- a/board/igep00x0/igep00x0.c
+++ b/board/igep00x0/igep00x0.c
@@ -169,7 +169,7 @@ void prcm_init(void)
* and sil_index will get the values for that SysClk for the
* appropriate silicon rev.
*/
- sil_index = get_cpu_rev() - 1;
+ sil_index = (get_cpu_rev() == CPU_3XX_ES10) ? 0 : 1;
/* Unlock MPU DPLL (slows things down, and needed later) */
sr32(CM_CLKEN_PLL_MPU, 0, 3, PLL_LOW_POWER_BYPASS);
diff --git a/board/omap3530beagle/omap3530beagle.c b/board/omap3530beagle/omap3530beagle.c
index 102c6d9..829a66d 100644
--- a/board/omap3530beagle/omap3530beagle.c
+++ b/board/omap3530beagle/omap3530beagle.c
@@ -439,7 +439,7 @@ void prcm_init(void)
* and sil_index will get the values for that SysClk for the
* appropriate silicon rev.
*/
- sil_index = get_cpu_rev() - 1;
+ sil_index = (get_cpu_rev() == CPU_3XX_ES10) ? 0 : 1;
/* Unlock MPU DPLL (slows things down, and needed later) */
sr32(CM_CLKEN_PLL_MPU, 0, 3, PLL_LOW_POWER_BYPASS);
diff --git a/board/omap3evm/omap3evm.c b/board/omap3evm/omap3evm.c
index 6048964..0ba5c55 100644
--- a/board/omap3evm/omap3evm.c
+++ b/board/omap3evm/omap3evm.c
@@ -271,7 +271,7 @@ void prcm_init(void)
* and sil_index will get the values for that SysClk for the
* appropriate silicon rev.
*/
- sil_index = get_cpu_rev() - 1;
+ sil_index = (get_cpu_rev() == CPU_3XX_ES10) ? 0 : 1;
/* Unlock MPU DPLL (slows things down, and needed later) */
sr32(CM_CLKEN_PLL_MPU, 0, 3, PLL_LOW_POWER_BYPASS);
--
1.7.4.1
2011/7/21 Ricardo Salveti de Araujo <ricardo...@linaro.org>:
> --
> --
> To unsubscribe from this group, email: x-loader+u...@googlegroups.com
> For more options: http://groups.google.com/group/x-loader?hl=en?hl=en
> Home Page: http://gitorious.org/x-loader
>
Good, looks good for me. Have my ack for the IGEP part
the ternary operator is unnecessary. get_cpu_rev() == CPU_3XX_ES10 will
already evaluate to 1 or 0. So you could:
sil_index = !(get_cpu_rev() == CPU_3XX_ES10);
--
balbi
Thanks!
Applied with Enric's Ack and Felipe's suggested change.
- Anand