[x-loader][PATCH 0/3] Fix some trivial warnings

10 views
Skip to first unread message

Enric Balletbo i Serra

unread,
Jul 29, 2011, 3:31:53 PM7/29/11
to x-lo...@googlegroups.com, Enric Balletbo i Serra
Hi,

These patch series fixes some trivial warnings.

Cheers,

Enric Balletbo i Serra (3):
Fix warning in lib/board.c
Fix warning in include/asm/arch/i2c.h
Fix warning in cpu/omap3/mmc.c

cpu/omap3/mmc.c | 4 ++--
include/asm/arch-omap3/i2c.h | 2 +-
lib/board.c | 1 +
3 files changed, 4 insertions(+), 3 deletions(-)

--
1.7.4.1

Enric Balletbo i Serra

unread,
Jul 29, 2011, 3:31:54 PM7/29/11
to x-lo...@googlegroups.com, Enric Balletbo i Serra
This patch fixes following warning:
board.c: In function ‘init_func_i2c’:
board.c:55:2: warning: implicit declaration of function ‘i2c_init’

Signed-off-by: Enric Balletbo i Serra <ebal...@gmail.com>
---
lib/board.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/board.c b/lib/board.c
index fac5f77..0f6b960 100644
--- a/lib/board.c
+++ b/lib/board.c
@@ -31,6 +31,7 @@
*/

#include <common.h>
+#include <i2c.h>
#include <part.h>
#include <fat.h>
#include <asm/arch/mem.h>
--
1.7.4.1

Enric Balletbo i Serra

unread,
Jul 29, 2011, 3:31:55 PM7/29/11
to x-lo...@googlegroups.com, Enric Balletbo i Serra
This patch fixes following warnings:
include/asm/arch/i2c.h:89:65: warning: "/*" within comment
include/asm/arch/i2c.h:90:8: warning: "/*" within comment

Signed-off-by: Enric Balletbo i Serra <ebal...@gmail.com>
---

include/asm/arch-omap3/i2c.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm/arch-omap3/i2c.h b/include/asm/arch-omap3/i2c.h
index 5fb0979..28ae5ca 100644
--- a/include/asm/arch-omap3/i2c.h
+++ b/include/asm/arch-omap3/i2c.h
@@ -86,7 +86,7 @@
#define I2C_CON_BE (1 << 14) /* Big endian mode */
#define I2C_CON_STB (1 << 11) /* Start byte mode (master mode only) */
#define I2C_CON_MST (1 << 10) /* Master/slave mode */
-#define I2C_CON_TRX (1 << 9) /* Transmitter/receiver mode /*
+#define I2C_CON_TRX (1 << 9) /* Transmitter/receiver mode */
/* (master mode only) */
#define I2C_CON_XA (1 << 8) /* Expand address */
#define I2C_CON_STP (1 << 1) /* Stop condition (master mode only) */
--
1.7.4.1

Enric Balletbo i Serra

unread,
Jul 29, 2011, 3:31:56 PM7/29/11
to x-lo...@googlegroups.com, Enric Balletbo i Serra
This patch fixes following warning:
mmc.c: In function ‘mmc_init’:
mmc.c:543:26: warning: assignment from incompatible pointer type

Signed-off-by: Enric Balletbo i Serra <ebal...@gmail.com>
---

cpu/omap3/mmc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/omap3/mmc.c b/cpu/omap3/mmc.c
index e0c63b0..3d53fae 100644
--- a/cpu/omap3/mmc.c
+++ b/cpu/omap3/mmc.c
@@ -516,10 +516,10 @@ unsigned char configure_mmc(mmc_card_data *mmc_card_cur)
return 1;
}
unsigned long mmc_bread(int dev_num, unsigned long blknr, lbaint_t blkcnt,
- void *dst)
+ unsigned long *dst)
{
omap_mmc_read_sect(blknr, (blkcnt * MMCSD_SECTOR_SIZE), &cur_card_data,
- (unsigned long *) dst);
+ dst);
return 1;
}

--
1.7.4.1

Gadiyar, Anand

unread,
Aug 3, 2011, 9:52:18 AM8/3/11
to x-lo...@googlegroups.com

All applied, thanks!

- Anand

Reply all
Reply to author
Forward
0 new messages