On Fri, 13 Aug 2021 16:01:56 -0700 Kevin B. McCarty wrote:
KBM> One problem I came across is that the macro EVT_GRID_CMD_RANGE_SELECT is no
KBM> longer defined in include/wx/generic/grid.h as it is in 3.1.4. According
KBM> to the docs [*] it has been replaced by EVT_GRID_CMD_RANGE_SELECTED, but
KBM> the backward name hasn't been kept for backwards compatibility.
KBM> Seems like this was an oversight,
Yes, indeed, thanks for noticing this. The backwards-compatible synonym
for this macro was forgotten in 415f080c80 (Split wxGrid RANGE_SELECT event
into SELECTING and SELECTED, 2020-07-27) and I've just added it now in
7b5783e4f8 (Restore accidentally removed EVT_GRID_CMD_RANGE_SELECT macro,
KBM> Additionally -- We're explicitly using --disable-compat30 in our
KBM> ./configure flags to make sure that we don't keep using old cruft, but the
KBM> old name EVT_GRID_RANGE_SELECT itself is now guarded by a macro for that,
KBM> so our builds under 3.1.5 don't see that either. Seems a little abrupt to
KBM> move the old spelling from "always available and the only option" status to
KBM> "deprecated and hidden by --disable-compat30" status in only a single point
KBM> release. Though maybe there is good reason for it...
If you use --disable-compat30, this indeed means that you don't want to
use any APIs that have better replacements now, so this makes sense to me.
The only alternative would be to always define, i.e. not deprecate it at
all, but then we'd have to keep it forever (well, until 3.6.0, which is
about the same thing).
OTOH I guess there is no real harm in keeping it and I do see several
packages use EVT_GRID_RANGE_SELECT at
But even more packages use EVT_GRID_CELL_CHANGE, which is disabled when 2.8
compatibility is turned off. So by this logic we shouldn't actually
deprecate it neither.
So, finally, I'm probably going to remove the compatibility checks around
the definitions of these macros, if there are no objections, as it really
doesn't cost us anything to keep them and it would save some work for
people upgrading to 3.2.
KBM> Regarding the above page, note that the description of
KBM> EVT_GRID_CMD_RANGE_SELECTED on that page erroneously says that the old name
KBM> of the macro was EVT_GRID_RANGE_SELECT rather than
I've fixed this too in the commit above, thanks for noticing this too!
TT-Solutions: wxWidgets consultancy and technical support