poor quality icons in wxGenericDirCtrl on macOS

[Andrew Trevorrow]

The attached image shows the icons used by wxGenericDirCtrl in

the widgets sample on macOS.  The top icons are from wxMac 3.0.5

and the bottom icons are from wxMac 3.2.7 (and, in my opinion, look

rather ugly).

Where are the source files for these icons?

Is there any call I can make so my apps use the older icons?

Thanks for any advice,

Andrew

[Vadim Zeitlin]

On Sun, 30 Mar 2025 09:57:20 +1100 Andrew Trevorrow wrote:

AT> The attached image shows the icons used by wxGenericDirCtrl in
AT> the widgets sample on macOS. The top icons are from wxMac 3.0.5
AT> and the bottom icons are from wxMac 3.2.7 (and, in my opinion, look
AT> rather ugly).
AT>
AT> Where are the source files for these icons?
AT> Is there any call I can make so my apps use the older icons?

This is rather strange because the code of wxGenericDirCtrl itself doesn't
seem to have changed since 3.0 and it uses the icons from wxArtProvider
just as it did before. And the code in wxArtProvider doesn't seem to have
changed either, so I don't understand why did the icons change.

In any case, you can customize these icons by using a custom
wxArtProvider. Of course, it would be nice to improve the default ones and
any work on this would be welcome. In particular, wxGenericDirCtrl code
should be modernized to use wxBitmapBundle in order to look better in high
DPI.

Regards,
VZ

--
TT-Solutions: wxWidgets consultancy and technical support
https://www.tt-solutions.com/

[Andrew Trevorrow]

On Sun, Mar 30, 2025 at 1:09 PM Vadim Zeitlin <va...@wxwidgets.org> wrote:

>  In any case, you can customize these icons by using a custom

> wxArtProvider. Of course, it would be nice to improve the default ones ...

But where are the files for the default icons located?

I thought they must be the xpm files in the art directory but

folder.xpm is identical in 3.0.5 and 3.2.7.

Andrew

[Vadim Zeitlin]

On Mon, 31 Mar 2025 08:21:53 +1100 Andrew Trevorrow wrote:

AT> On Sun, Mar 30, 2025 at 1:09 PM Vadim Zeitlin <va...@wxwidgets.org> wrote:
AT>
AT> > In any case, you can customize these icons by using a custom
AT> > wxArtProvider. Of course, it would be nice to improve the default ones ...
AT>
AT> But where are the files for the default icons located?
AT> I thought they must be the xpm files in the art directory

Yes, they are.

AT> but folder.xpm is identical in 3.0.5 and 3.2.7.

This means that something else has changed somewhere, but I don't know
where, sorry.

[Maarten Bent]

Maybe caused by the change of rescale method from HIGH to NEAREST?
https://github.com/wxWidgets/wxWidgets/commit/84cb293e712ba2db7a946a166a83e1d0fdec3297

Maarten

[Andrew Trevorrow]

It turns out the default icons are coming from the art/tango directory
and the files in there have changed from 3.0.5 to 3.2.7.

To use the xpm files in the art directory you need to specify --disable-arttango
on the configure line. The attached image shows what those icons look like
in the widgets sample. Better quality than the default 3.2.7 icons but perhaps
not as nice as the default 3.0.5 icons.

Andrew