[wx-testers] sockets sample makefile breaks unix builds

[Gilles Depeyrot]

Hi,

We might as well start using the wxTesters list for prerelease tests :-)

The sockets sample makefile breaks unix builds because if currently
unconditionally includes _resources.o files which are only created when
compiling under Windows.

make: *** No rule to make target `sockets.rc', needed by
`sockets_resources.o'. Stop.
make: *** [samples/sockets] Error 2

Both the ipc sample and the sockets sample differ from the other samples
because two programs are built... and therefore the makefiles are not
created in the same way (they don't use makeprog.env).

Any ideas how this should be corrected?

Regards,
Gilles

--
Gilles Depeyrot <mailto:Gilles....@wanadoo.fr>
<http://perso.wanadoo.fr/gilles.depeyrot>

[Vadim Zeitlin]

On Wed, 21 Nov 2001 22:43:34 +0100 Gilles Depeyrot <Gilles....@wanadoo.fr> wrote:

GD> We might as well start using the wxTesters list for prerelease tests :-)

We're at least 2 here :-) I'm also cc'ing this to Mattia - sorry if you're
subscribed too.

GD> The sockets sample makefile breaks unix builds because if currently
GD> unconditionally includes _resources.o files which are only created when
GD> compiling under Windows.
GD>
GD> make: *** No rule to make target `sockets.rc', needed by
GD> `sockets_resources.o'. Stop.
GD> make: *** [samples/sockets] Error 2

I don't understand what is it trying to do - there is no sockets.rc file
at all, only server.rc and client.rc. It seems this has been changed in 1.7
of Makefile.in by Mattia - could you please check if it was intended?

GD> Both the ipc sample and the sockets sample differ from the other samples
GD> because two programs are built... and therefore the makefiles are not
GD> created in the same way (they don't use makeprog.env).
GD>
GD> Any ideas how this should be corrected?

Probably by reproducing the relevant parts of makeprog.env by hand in
them?

Regards,
VZ

[Mattia Barbon]

> On Wed, 21 Nov 2001 22:43:34 +0100 Gilles Depeyrot
<Gilles....@wanadoo.fr> wrote:
>
> GD> We might as well start using the wxTesters list for prerelease
tests :-)
>
> We're at least 2 here :-) I'm also cc'ing this to Mattia - sorry if
you're
> subscribed too.

We're _three_ !

> GD> The sockets sample makefile breaks unix builds because if
currently
> GD> unconditionally includes _resources.o files which are only created
when
> GD> compiling under Windows.
> GD>
> GD> make: *** No rule to make target `sockets.rc', needed by
> GD> `sockets_resources.o'. Stop.
> GD> make: *** [samples/sockets] Error 2
>
> I don't understand what is it trying to do - there is no sockets.rc
file
> at all, only server.rc and client.rc. It seems this has been changed
in 1.7
> of Makefile.in by Mattia - could you please check if it was intended?

I don't remmber, but I'm going to correct it...

> GD> Both the ipc sample and the sockets sample differ from the other
samples
> GD> because two programs are built... and therefore the makefiles are
not
> GD> created in the same way (they don't use makeprog.env).
> GD>
> GD> Any ideas how this should be corrected?
>
> Probably by reproducing the relevant parts of makeprog.env by hand in
> them?

...like this

OBJECTS =$(PROGRAM).o
DEPFILES=$(PROGRAM).d

# this can't be called all
dummy:
$(MAKE) PROGRAM=client all
$(MAKE) PROGRAM=server all

include ../../src/makeprog.env

tested on cygwin and linux; committing now

Regards
Mattia