Add support for handling characters outside of BMP to wxMSW (PR #27016)
VZ
See #25135.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27016
Commit Summary
- 9bdab84 Initialise wxKeyEvent members in their declarations
- 7d85e3a Always initialize wxKeyEvent::m_rawCode and m_rawFlags
- 92162ed Add wxWindow::SendAfterCharEvent()
- 78f071c Add support for non-BMP characters in wxKeyEvent in wxMSW
File Changes
(7 files)
- M include/wx/event.h (45)
- M include/wx/msw/window.h (5)
- M interface/wx/event.h (36)
- M samples/keyboard/keyboard.cpp (8)
- M src/common/event.cpp (5)
- M src/msw/combobox.cpp (3)
- M src/msw/window.cpp (122)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27016.patch
- https://github.com/wxWidgets/wxWidgets/pull/27016.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27016)Hmm, returning to this to update the code to use the new function, I think there is anothing preexisting bug here: currently wxString::Format("%c", wxUniChar{0x1F600}) doesn't work under MSW: it produces \uF600 as it simply discards the high 16 bits. This needs to be fixed to allow replacing GetUnicodeKey() with GetUnicodeChar() easily in the existing code...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 9 commits.
- 9992152 Fix bug with broken AUI sash drag in some layout
- 1e2e4d7 Initialise wxKeyEvent members in their declarations
- dbf58d2 Always initialize wxKeyEvent::m_rawCode and m_rawFlags
- 82f2d9b Add wxWindow::SendAfterCharEvent()
- 6b4a5fd Add support for non-BMP characters in wxKeyEvent in wxMSW
- 9bf5a10 Pass wxUniChar to wxVListBoxComboPopup::HandleKey()
- f4af4d5 Handle characters outside of BMP in wxStyledTextCtrl under MSW
- 81ea3c8 Handle characters outside of BMP in wxRichTextCtrl under MSW
- 2816bee Use wxKeyEvent::GetUnicodeChar() instead of GetUnicodeKey()
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27016)This one should be ready too now.
An example of what we gain: with the changes here I can insert emojis from Windows emoji panel in the control in stc sample, when previously this didn't work at all.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27016)Please let me know if anybody plans to review this. Otherwise I'll merge it soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.