change SetHelpEventPosition to SetHelpIDEvent (PR #25812)
StevenPHirshman
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25812
Commit Summary
- 5d89d67 Update cshelp.cpp
- dc9078f Merge branch 'master' of https://github.com/StevenPHirshman/wxWidgets
- 45aefbf added virtual SetHelpEventPos
- d01f5a4 Replace SetHelpEventPos with SetHelpIdAtPoint
File Changes
(5 files)
- M include/wx/tbarbase.h (3)
- M include/wx/window.h (3)
- M src/common/cshelp.cpp (3)
- M src/common/tbarbase.cpp (14)
- M src/common/wincmn.cpp (3)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25812.patch
- https://github.com/wxWidgets/wxWidgets/pull/25812.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25812)Err, why open a new PR instead of (force, if necessary) pushing to #25809? Please push there and close this one or if you intend to use this one, close the other one.
In any case, there are still build errors, please open the web page in your browser and click on the links to see them.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
StevenPHirshman left a comment (wxWidgets/wxWidgets#25812)***@***.***
From: VZ ***@***.***>
Sent: Thursday, September 18, 2025 3:56 PM
To: wxWidgets/wxWidgets ***@***.***>
Cc: StevenPHirshman ***@***.***>; Author ***@***.***>
Subject: Re: [wxWidgets/wxWidgets] change SetHelpEventPosition to SetHelpIDEvent (PR #25812)
[Image removed by sender.]vadz left a comment (wxWidgets/wxWidgets#25812)<https://github.com/wxWidgets/wxWidgets/pull/25812#issuecomment-3309434988>
Err, why open a new PR instead of (force, if necessary) pushing to #25809<https://github.com/wxWidgets/wxWidgets/pull/25809>? Please push there and close this one or if you intend to use this one, close the other one.
In any case, there are still build errors, please open the web page in your browser and click on the links to see them.
—
You are receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
oneeyeman1
oneeyeman1 left a comment (wxWidgets/wxWidgets#25812)@StevenPHirshman ,
How are you trying to upload them?
Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25812)I tried to manually upload the 4 files that I changed but they are not getting updated. What am I doing wrong?
Sorry, I've never used file upload interface, so I don't know. If you can use normal Git, please do.
Also, please strip quoted contents from your email replies, this makes the PR comments quite unreadable. Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
StevenPHirshman left a comment (wxWidgets/wxWidgets#25812)I tried dragging and dropping the files in the file upload box. That didn't seem to work. What is working is if I edit the files online.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
StevenPHirshman left a comment (wxWidgets/wxWidgets#25812)I am about ready to give up. My files keep erroring out in the "Check for trailing whitespace and TABs" test. I don't know what to do to fix it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
oneeyeman1
oneeyeman1 left a comment (wxWidgets/wxWidgets#25812)@StevenPHirshman ,
Please install "git for windows" if you are on windows and then use the regular way to do that : git add&& git commit -m && git push. Didn't you make a PR that way?
Thank you.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25812)You probably use a text editor on Windows that uses \r\n for new lines. The wxWidgets files expect \n (unix-style) new lines.
I think the easiest way to deal with this is to use an editor that supports editorconfig. Then it will automatically use the correct editor settings (\n new-lines, 4-spaces indentation, no trailing white-space).
The other error seems to be two new-lines at the end of the file, make sure there is only one.
But all these errors happen in the other PR you opened. Maybe move the conversation there?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
StevenPHirshman left a comment (wxWidgets/wxWidgets#25812)I will try to use a different editor. Thank you for the suggestion.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman pushed 1 commit.
- 044b3b0 Delete include/wx/window.h
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman pushed 1 commit.
- 722cdc2 Delete src/common/cshelp.cpp
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman pushed 1 commit.
- 4fbc8f0 Delete src/common/tbarbase.cpp
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman pushed 1 commit.
- 8152db1 Delete src/common/wincmn.cpp
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman pushed 1 commit.
- e59b8b2 Delete include/wx/tbarbase.h
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
StevenPHirshman
@StevenPHirshman commented on this pull request.
removed old files
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25812)Sorry, I really appreciate that you're trying to help, but you are doing something really, really weird, I have no idea why did you think that removing the files could be a good idea.
I'm closing this, please make the modifications in your own fork of this repository and once you see that everything is good there, please push your changes to #25809 or, if you really can't do it, open a new PR.
Of course, if you have any questions, please do ask them, but I have the impression that this is going nowhere.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Closed #25812.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.