Dark mode colors do not match Windows 11 (Issue #26404)

[Steve Cornett]

stevecor created an issue (wxWidgets/wxWidgets#26404)

Some color values in wxDarkModeSettings::GetColour() do not match what I see with supplied apps in Windows 11 25H2, uncustomized dark mode.

To determine color values, I used the Snipping Tool to capture an actual color shown, pasted into Paint, used the "Color picker" tool, and clicked the "Edit colors" button to see the RGB value.

• wxSYS_COLOUR_INFOBK. In File Explorer, hover over a toolbar button. The tooltip background color is 0x2d2d2d, not 0x202020.
• Text colors. Text colors are pure white, not 0xe0e0e0. Before sampling, maximize text size by going to Settings: Accessibility: Text size and set to max. In File Explorer, all text is white. The Notepad menu text is white. To get a proper color, sample the center of horizontal or vertical letter strokes.
• wxSYS_COLOUR_HIGHLIGHT. In File Explorer, select an item. The background color is 0x505050, not 0x9e5315.

Proposed changes:

diff --git a/src/msw/darkmode.cpp b/src/msw/darkmode.cpp
index 9ff28b6fe8..39218e6ad5 100644
--- a/src/msw/darkmode.cpp
+++ b/src/msw/darkmode.cpp
@@ -312,11 +312,13 @@ wxColour wxDarkModeSettings::GetColour(wxSystemColour index)

         case wxSYS_COLOUR_ACTIVECAPTION:
         case wxSYS_COLOUR_APPWORKSPACE:
-        case wxSYS_COLOUR_INFOBK:
         case wxSYS_COLOUR_LISTBOX:
         case wxSYS_COLOUR_WINDOW:
             return wxColour(0x202020);

+        case wxSYS_COLOUR_INFOBK:
+            return wxColour(0x2d2d2d);
+
         case wxSYS_COLOUR_BTNTEXT:
         case wxSYS_COLOUR_CAPTIONTEXT:
         case wxSYS_COLOUR_HIGHLIGHTTEXT:
@@ -325,7 +327,7 @@ wxColour wxDarkModeSettings::GetColour(wxSystemColour index)
         case wxSYS_COLOUR_LISTBOXTEXT:
         case wxSYS_COLOUR_MENUTEXT:
         case wxSYS_COLOUR_WINDOWTEXT:
-            return wxColour(0xe0e0e0);
+            return *wxWHITE;

         case wxSYS_COLOUR_HOTLIGHT:
             return wxColour(0xe48435);
@@ -345,10 +347,12 @@ wxColour wxDarkModeSettings::GetColour(wxSystemColour index)
         case wxSYS_COLOUR_LISTBOXHIGHLIGHT:
             return wxColour(0x626262);

-        case wxSYS_COLOUR_HIGHLIGHT:
         case wxSYS_COLOUR_MENUHILIGHT:
             return wxColour(0x9e5315);

+        case wxSYS_COLOUR_HIGHLIGHT:
+            return wxColour(0x505050);
+
         case wxSYS_COLOUR_BTNHIGHLIGHT:
             return wxColour(0x777777);

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/26404@github.com>