Make wxItemId::m_pItem private (PR #25926)
vvs31415
Call public wxItemId::GetID() instead
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25926
Commit Summary
- 3266f65 Make wxItemId::m_pItem private
File Changes
(5 files)
- M include/wx/itemid.h (4)
- M include/wx/treebase.h (4)
- M src/generic/treectlg.cpp (2)
- M src/msw/dragimag.cpp (2)
- M src/msw/treectrl.cpp (14)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25926.patch
- https://github.com/wxWidgets/wxWidgets/pull/25926.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
> @@ -40,9 +40,7 @@ class wxItemId
void Unset() { m_pItem = nullptr; }
- // This field is public *only* for compatibility with the old wxTreeItemId
We can apply the rest of this PR, but I don't want to change this, I'm almost certain that there is existing code using m_pItem and it's not worth breaking it without any real gain.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
vvs31415
@vvs31415 pushed 1 commit.
- b1b9958 Do not use wxItemId::m_pItem directly
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25926)Thanks, I'll merge and push this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.