Error when building tif_jpeg.c (Issue #26197)
Dmitrii Serebriannikov
serebdp created an issue (wxWidgets/wxWidgets#26197)Build System Used
I build wxWidgets and/or my application using:
- CMake
- configure
- mingw32-make with makefile.gcc
- MSBuild (Microsoft Visual Studio solution file)
- nmake with makefile.vc
- Xcode
Description
Yesterday I fetched the wxWidgets repository master branch and I faced a build error when compiling the wxWidgets static library :
In file included from ..\..\src\jpeg/jpeglib.h:25, from ../../src/tiff/libtiff/tif_jpeg.c:84: ..\..\src\jpeg/jconfig.h:9:10: fatal error: wx/setup.h: No such file or directory 9 | #include "wx/setup.h" | ^~~~~~~~~~~~ compilation terminated.
Of course I follow the required procedure, i.e. i clean library first using make, then i create the setup.h file and run the library compilation after.
It seems like the problem appeared due to the recent commit f1df26641a1d3621639ff25df5f787854a4e6628 where the macro _WIN32 was replaced by _MSC_VER and therefore wx/setup.h was included in tif_jpeg.c file. But it didn't work because the wx/setup.h file path is not included in the WXTIFF_CFLAGS variable in the makefile.gcc file.
WXTIFF_CFLAGS = -I..\..\src\zlib -I..\..\src\jpeg -I..\..\src\tiff\libtiff \ $(__DEBUGINFO) $(__OPTIMIZEFLAG) $(__THREADSFLAG) -DNDEBUG $(CPPFLAGS) \ $(CFLAGS)
Platform and version information
- wxWidgets version you are building: latest version of master branch (17.02.2026)
- wxWidgets port you are building: wxMSW
- OS and its version: Windows 10 1809
- Compiler being used: gcc 15.2
- Non-default compiler options, if any :
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26197)Thanks for reporting. I wrongly updated the libjpeg submodule. There was a discrepancy between _WIN32 at the opening #if and a _MSC_VER comment at the closing #endif of jconfig.h, so I naively thought both could be _MSC_VER. I'll prepare a fix.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26197)@MaartenBent Can I push jpeg submodule to 88cf215 (Restore _WIN32 check in jconfig.h, 2026-02-17) to fix this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#26197)I created #26199 for this, but it needs the zlib PR to be merged first.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.