[wxWidgets/wxWidgets] wxQt: Suppress the selection changed event on the first display of th… (PR #26194)
AliKet
…e wxListCtrl.
Since the wxEVT_LIST_ITEM_SELECTED event is not generated in the other ports when the wxListCtrl is shown for the first time, do not generate it under wxQt for consistency.
The artprov sample would assert here:
because m_client were not initialized yet when this handler is executed:
https://github.com/wxWidgets/wxWidgets/blob/4e4159836df134eb87d84e800ca11f45ed8e7d5e/samples/artprov/artbrows.cpp#L241-L246
Initializing m_client before calling SetItemState() here
https://github.com/wxWidgets/wxWidgets/blob/4e4159836df134eb87d84e800ca11f45ed8e7d5e/samples/artprov/artbrows.cpp#L232-L236
fixes the problem, but will just hide the inconsistency of wxQt with the other ports.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26194
Commit Summary
- 53d1041 wxQt: Suppress the selection changed event on the first display of the wxListCtrl.
File Changes
(1 file)
- M src/qt/listctrl.cpp (4)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26194.patch
- https://github.com/wxWidgets/wxWidgets/pull/26194.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26194)Thanks for fixing this, will merge soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.