Fix installation of webkit2_ext ignores wxBUILD_INSTALL_LIBRARY_DIR (PR #25736)
Chris Mayo
If I configure a CMake installation with -DwxBUILD_INSTALL_LIBRARY_DIR=/usr/lib64
webkit2_extu-3.3.1.so is installed in /usr/lib/wx/3.3.1/web-extensions - unlike when using autotools, when it is installed with the other binary libraries under /usr/lib64.
Fixed by using wx_get_install_dir() from build/cmake/functions.cmake as used there by wx_add_library().
These two also install in /usr/lib/:
/usr/lib/wx/config/gtk3-unicode-3.3
/usr/lib/wx/include/gtk3-unicode-3.3/wx/setup.h
which is also a change when installing with CMake as compared to autotools, which might cause some downstream scripting changes, but they aren't binary, so...
3.3.1 on Linux.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25736
Commit Summary
- e7c5923 Fix installation of webkit2_ext ignores wxBUILD_INSTALL_LIBRARY_DIR
File Changes
(1 file)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25736.patch
- https://github.com/wxWidgets/wxWidgets/pull/25736.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25736)Thanks, this looks good to me.
Unless @MaartenBent has any comments, I'll merge this soon.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25736)Looks good.
There are indeed a few more files that use the hard-coded lib/bin folders instead of the user-configured folders, I'll try to fix those at some point.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.