WebP in MSVC solutions (PR #25339)

63 views
Skip to first unread message

Maarten

unread,
Apr 17, 2025, 4:59:53 PM4/17/25
to wx-...@googlegroups.com, Subscribed

An extension of #25205

I created a new webp project that is built by the Visual Studio solutions. It does not seem to need an compile or link options.

Because of the huge diff I put this in a separate PR to keep the other one readable.

This sets #define wxUSE_LIBWEBP 1 in all setup.h, so it might break some other builds.
Next step is to create webp.bkl so it is added to makefile.gcc and makefile.vc as well.

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25339

Commit Summary

File Changes

(175 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339@github.com>

Maarten

unread,
Apr 17, 2025, 6:00:43 PM4/17/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 1 commit.

  • a566bc1 Fix outdated vcxproj files

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/d1fb6cee3be3d855794f433891d5db28525a0157/after/a566bc10df7e0fb7f3a803fac5868c32bdbd3ab0@github.com>

Maarten

unread,
Apr 24, 2025, 4:03:09 PM4/24/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 3 commits.

  • 9b70782 Disable webp for shipped XCode projects
  • 460c500 Add webp bakefile, update configure
  • 7b40faf rebake and autogen

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/a566bc10df7e0fb7f3a803fac5868c32bdbd3ab0/after/7b40faf1233abb20cc7758128ce45d7d6f7eab9a@github.com>

Maarten

unread,
Apr 24, 2025, 4:34:43 PM4/24/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 30 commits.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/7b40faf1233abb20cc7758128ce45d7d6f7eab9a/after/6711b413536d9f1d1050ca372c8b509eb15ff4a7@github.com>

Maarten

unread,
Apr 25, 2025, 3:01:09 PM4/25/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 1 commit.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/6711b413536d9f1d1050ca372c8b509eb15ff4a7/after/ff1bac6b716d8316a146f5ceb77696684877b49d@github.com>

Maarten

unread,
Apr 26, 2025, 9:33:11 AM4/26/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 1 commit.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/ff1bac6b716d8316a146f5ceb77696684877b49d/after/10fa7f8aa850cd326ce0f70205093f3387b0037b@github.com>

Maarten

unread,
Apr 26, 2025, 9:41:31 AM4/26/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 1 commit.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/10fa7f8aa850cd326ce0f70205093f3387b0037b/after/27635c917246c15376111d647c51ec0388ca0d56@github.com>

Maarten

unread,
Apr 26, 2025, 10:49:43 AM4/26/25
to wx-...@googlegroups.com, Subscribed
MaartenBent left a comment (wxWidgets/wxWidgets#25339)

Xcode projects always defines HAVE_CONFIG_H, causing webp to look for a non-existing file.

https://github.com/wxWidgets/wxWidgets/blob/9495129c5eda0b0a1147cf90f122408787dd4fde/build/osx/wx.xcconfig#L16

Adding just an empty src/web/config.h to the libwebp repo should fix this. But we need a libwebp repo for that.

@vadz can you fork https://github.com/webmproject/libwebp (or create a clone of https://chromium.googlesource.com/webm/libwebp), create a wx branch, and make it the default branch? Thanks.
With that, I should also be able to finalize #25205.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/c2832285412@github.com>

VZ

unread,
Apr 26, 2025, 12:14:37 PM4/26/25
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#25339)

I guess the proper fix would be to use wxHAVE_CONFIG_H for our use (and the same for all the other HAVE_XXX, of course), but for now I've done what you proposed, i.e. created https://github.com/wxWidgets/libwebp/ with default wx branch.

TIA!

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/c2832390970@github.com>

Maarten

unread,
Apr 26, 2025, 6:42:31 PM4/26/25
to wx-...@googlegroups.com, Subscribed
MaartenBent left a comment (wxWidgets/wxWidgets#25339)

Thanks. Maybe before anyone thinks of using it, can you force the wx branch to tag v1.5.0 ?

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/c2832679547@github.com>

Maarten

unread,
Apr 27, 2025, 11:18:15 AM4/27/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 20 commits.

  • ab972bf Add support for WebP image file format via libwebp.
  • ca7ba60 CMake: Fix iOS OpenGL warning
  • 2728bc6 Add wxImage::SetDataRGBA
  • 0bf4cb5 Use WebP as built-in submodule
  • 2aea23b Update wxWEBPHandler
  • 3a45474 Add wxWebPDecoder for WebP animations
  • 53d1f89 Invalidate wxGenericAnimationCtrl size when fitting image
  • 7b66218 Add WebP image to image sample
  • 32cc9ad Show frames of animated images in image sample
  • 40ef205 Add WebP format to animation sample
  • f924add Update and generate build files
  • 95ef5ee Update wxWEBPHandler tests
  • 448a900 Update wxWEBPHandler and wxWebPDecoder documentation
  • b56f80d Fix outdated vcxproj files
  • 46b7749 Add libwebp to MSVS solutions
  • c965090 Add libwebp bakefile, update configure
  • 8ac1ea3 Recreate build-files
  • 9ef9da5 Add libwebp to Xcode projects
  • c31aa53 Install libwebp in Cirrus CI
  • 10f2228 Enable libwebp in setup.h

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/27635c917246c15376111d647c51ec0388ca0d56/after/10f2228dd2a128bc56f26400df6ffe6b0d66c778@github.com>

Maarten

unread,
Apr 27, 2025, 12:22:55 PM4/27/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 2 commits.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/10f2228dd2a128bc56f26400df6ffe6b0d66c778/after/c6267871b3161886f0ca8c64dd4e4d478da9eabc@github.com>

Maarten

unread,
Apr 27, 2025, 12:55:23 PM4/27/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 22 commits.

  • ec66173 Add support for WebP image file format via libwebp.
  • 9d183e8 CMake: Fix iOS OpenGL warning
  • 698f248 Add wxImage::SetDataRGBA
  • 2fb21a0 Use WebP as built-in submodule
  • 73ec81c Update wxWEBPHandler
  • d618126 Add wxWebPDecoder for WebP animations
  • 5d2ea34 Invalidate wxGenericAnimationCtrl size when fitting image
  • 8a350ba Add WebP image to image sample
  • b1b05fc Show frames of animated images in image sample
  • 898627a Add WebP format to animation sample
  • 58943ce Update and generate build files
  • b141d63 Update wxWEBPHandler tests
  • 4b41d78 Update wxWEBPHandler and wxWebPDecoder documentation
  • e9c8d88 Fix outdated vcxproj files
  • 8c07d89 Add libwebp to MSVS solutions
  • 0bb5834 Add libwebp bakefile, update configure
  • b1a1eab Recreate build-files
  • 1f7066b Add libwebp to Xcode projects
  • eed1d8c Install libwebp in Cirrus CI
  • 936c98d Enable libwebp in setup.h
  • 73bf518 Fix configure
  • 4c612e2 Fix builtin webp include

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/c6267871b3161886f0ca8c64dd4e4d478da9eabc/after/4c612e2fa358240ca3e469493b3b0bef87c9a5c6@github.com>

Maarten

unread,
May 10, 2025, 12:26:55 PM5/10/25
to wx-...@googlegroups.com, Push

@MaartenBent pushed 20 commits.

  • 15a2a62 Add support for WebP image file format via libwebp.
  • 2ec276a CMake: Fix iOS OpenGL warning
  • e040b0c Add wxImage::SetDataRGBA
  • d408cea Use WebP as built-in submodule
  • 412cfe9 Update wxWEBPHandler
  • 6fbef0b Add wxWebPDecoder for WebP animations
  • e2d6bdf Invalidate wxGenericAnimationCtrl size when fitting image
  • a308725 Add WebP image to image sample
  • be1ab5b Show frames of animated images in image sample
  • 090282a Add WebP format to animation sample
  • d6209ab Update and generate build files
  • 312fa74 Update wxWEBPHandler tests
  • bfb5d62 Update wxWEBPHandler and wxWebPDecoder documentation
  • ad80d9c Fix outdated vcxproj files
  • b0b3da6 Add libwebp to MSVS solutions
  • 0332afd Add libwebp bakefile, update configure
  • fd14294 Recreate build-files
  • 34a5c28 Add libwebp to Xcode projects
  • 8ee27b8 Install libwebp in Cirrus CI
  • 00d31dc Enable libwebp in setup.h

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/before/4c612e2fa358240ca3e469493b3b0bef87c9a5c6/after/00d31dc3bdb65ce3d9a271faed18ca453bb05301@github.com>

VZ

unread,
May 11, 2025, 12:55:17 PM5/11/25
to wx-...@googlegroups.com, Subscribed

Merged #25339 into master.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25339/issue_event/17606106884@github.com>

Reply all
Reply to author
Forward
0 new messages