[wxWidgets/wxWidgets] wxOSX: Don’t crash in wxNativeFontInfo::FromString() (PR #26411)
Václav Slavík
This PR fixes crash when deserializing font info from string representation. This happens if the font face is missing on the current system; I don’t know if it can happen under other circumstances too.
Split into two commits:
-
9c18a70 — this one is clear, no code should crash, period. This results in some font being created, bug degraded (no face, fallback traits).
-
9ad3f86 — treats this failure as deserialization failure, so that the missing font is detectable, but I’m not sure if that’s the intention there. E.g. wxGTK seems to accept such fonts unless I’m mistaken...
Applies to 3.2 as-is.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26411
Commit Summary
- 9c18a70 Don't crash on unexpected CTFontDescription content
- 9ad3f86 wxOSX: fail wxNativeFontInfo::FromString if missing
File Changes
(2 files)
- M src/osx/carbon/font.cpp (18)
- M tests/font/fonttest.cpp (9)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26411.patch
- https://github.com/wxWidgets/wxWidgets/pull/26411.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.