WebView2 build issue in GH action (maybe need to update WebView2 version) (Issue #25815)
Blake-Madden
Blake-Madden created an issue (wxWidgets/wxWidgets#25815)Build System Used
Windows latest in GH action.
CMake static build.
Description
On my local Windows 11 all works well, but now I get these errors when I statically build a project on Windows-latest in a GH action:
wxWidgets_lib/libs/webview/packages/Microsoft.Web.WebView2.1.0.1722.45/WebView2.idl:2027: warning: included file 'AppWindow.cpp' is not found.
Sleuthing around I see mention of a bug in this IDL file in some versions (?) of 1.0.1722.45 of WebView2 (although my local build looks OK and doesn't try to import 'AppWindow.cpp' anywhere).
The recommendation is to upgrade to 1.0.1901.177, which is the newest LTS release.
Anyway that this can be done in our build system? I see where this is done in "build\cmake\lib\webview\CMakeLists.txt", but I don't know how the SHA256 is generated.
Platform and version information
- wxWidgets: trunk
- Windows latest on GH
- CMake
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25815)You can use any version you want. Download and extract it in 3rdparty/webview2 and CMake should find it automatically. Or extract it somewhere else and let WEBVIEW2_PACKAGE_DIR point to it.
Maybe you can use it to verify that the error (or is it just a warning?) is fixed in newer versions.
We can also update the default version. Where did you find that 1.0.1901.177 is an LTS version?
It is already 2 years old, maybe we can update to the latest available version (currently 1.0.3485.44).
I don't see the hash mentioned on the nuget website, so you probably have to calculate it yourself. Using powershell / 7zip / sha256sum or any other tool.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Maarten
MaartenBent left a comment (wxWidgets/wxWidgets#25815)Also related to Webview2, when running an application like the webview sample, the following warning is shown in the debug window:
Warning: AddWebResourceRequestedFilter without SourceKind parameter is deprecated! It does not behave as expected for iframes.Please use AddWebResourceRequestedFilterWithRequestSourceKinds instead. For more information, please see https://go.microsoft.com/fwlink/?linkid=2286319
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
Blake-Madden left a comment (wxWidgets/wxWidgets#25815)Also related to Webview2, when running an application like the webview sample, the following warning is shown in the debug window:
Warning: AddWebResourceRequestedFilter without SourceKind parameter is deprecated! It does not behave as expected for iframes.Please use AddWebResourceRequestedFilterWithRequestSourceKinds instead. For more information, please see https://go.microsoft.com/fwlink/?linkid=2286319
This will require changing the ICoreWebView2_2 interface to ICoreWebView2_22, which probably isn't trivial. But anyway, the first step to fixing this is updating the WebView2 that we download to at least 1.0.2365.46 (AddWebResourceRequestedFilterWithRequestSourceKinds's requirement). I'll make a PR for that.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Blake-Madden
Blake-Madden left a comment (wxWidgets/wxWidgets#25815)I don't see the hash mentioned on the nuget website, so you probably have to calculate it yourself. Using powershell / 7zip / sha256sum or any other tool.
PowerShell's Get-FileHash works, thanks! I'll explain that in a PR.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.