MSW: Dark mode border for wxTextCtrl based on DarkMode_DarkTheme (PR #26805)
Steve Cornett
Adjust colors used in wxTextCtrl::MSWDrawThemeBorder() to match how the Edit control is rendered with the DarkMode_DarkTheme theme rather than the WinUI 3 TextBox control. This should improve the appearance on a variety of backgrounds. This is how the control appears in the common dialogs with #26780 where DarkMode_DarkTheme is used.
See #26800.
Image: image (view on web)You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26805
Commit Summary
- 872f90f Dark mode border for wxTextCtrl based on DarkMode_DarkTheme
File Changes
(1 file)
- M src/msw/textctrl.cpp (47)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26805.patch
- https://github.com/wxWidgets/wxWidgets/pull/26805.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26805)Thanks for your continued efforts to improve this. I have to admit that personally I still find both the blue (for focused controls) and the too bright (IMHO) bottom border colour (for inactive controls) pretty jarring, but if this is the de facto standard, I guess we should follow it, so I'll apply this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.