Respect swapped mouse buttons in GUI tests (PR #26723)
Richard Thomson
Add primary and secondary mouse-button helpers to the test harness and use them in wxUIActionSimulator-based GUI tests instead of relying on physical left and right buttons.
Document the convention for new GUI tests.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26723
Commit Summary
- 212214b Respect swapped mouse buttons in GUI tests
File Changes
(8 files)
- M docs/contributing/how-to-write-unit-tests.md (5)
- M include/wx/uiaction.h (32)
- M tests/controls/gridtest.cpp (8)
- M tests/controls/listbasetest.cpp (2)
- M tests/controls/listctrltest.cpp (2)
- M tests/controls/treectrltest.cpp (4)
- M tests/events/propagation.cpp (4)
- M tests/test.cpp (30)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26723.patch
- https://github.com/wxWidgets/wxWidgets/pull/26723.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Richard Thomson
LegalizeAdulthood left a comment (wxWidgets/wxWidgets#26723)Without this, I have to unswap my mouse buttons for the GUI tests to pass.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz commented on this pull request.
I'm not sure if this is the best way to do it, shouldn't we just translate LEFT to RIGHT inside wxMSW wxUIActionSimulator implementation if the mouse buttons are swapped? It wouldn't require any changes to the code (maybe just a mention in the docs) and seems simpler.
> private:
+ static bool MouseButtonsSwapped()
+ { return wxSystemSettings::GetMetric(wxSYS_SWAP_BUTTONS) != 0; }
This should be moved to src/common/uiactioncmn.cpp to avoid including wx/settings.h from here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.