Re: Don't accumulate timer events when calling YieldFor() in wxMSW (PR #26204)
VZ
vadz left a comment (wxWidgets/wxWidgets#26204)@dsa-t @marekr Please let me know if you see any problems in KiCad with this change or if it's fine to merge it.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Repeated calls to this function could result in unbounded input queue growth because timer events were synthesized for each call to it, put back into the queue if not processed, and then another event would be synthesized again during the next call.
Fix this by discarding timer events instead. This is not ideal when using one-off timers, but better than the alternative.
Document this limitation of wxMSW.
Closes #26192.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26204
Commit Summary
- 2ae8e8b Don't accumulate timer events when calling YieldFor() in wxMSW
File Changes
(4 files)
- M interface/wx/event.h (9)
- M interface/wx/evtloop.h (5)
- M interface/wx/progdlg.h (9)
- M src/msw/evtloop.cpp (21)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26204.patch
- https://github.com/wxWidgets/wxWidgets/pull/26204.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26204)We need to merge this soon for it to be included in 3.3.2, so any feedback would be very welcome.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26204)Applied in the commit above, please let me know if this results in any new problems.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.