wxrc: `GetInternalFileName`: Call to `Printf`: Format string arg is now constant. (PR #24547)
DoctorNoobingstoneIPresume
In the original code:
s.Printf(wxFileNameFromPath(parOutput) + wxT("$%03i-") + name2, i);
if wxFileNameFromPath(parOutput2) or name2 had contained '%' (format specifiers), the results would have been bad.
These strings are now given as additional arguments to Printf (corresponding to "%s" format specifiers),
and the format string argument itself is now constant.
This is a replacement of 9a5d32d as per #24437 (comment).
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/24547
Commit Summary
- 2b8cba8 wxrc: `GetInternalFileName`: Call to `Printf`: Format string arg is now constant.
File Changes
(1 file)
- M utils/wxrc/wxrc.cpp (5)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/24547.patch
- https://github.com/wxWidgets/wxWidgets/pull/24547.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
Applying as well, thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
DoctorNoobingstoneIPresume
You are most welcome, thank you for this and for all your work !! 🌈
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.