wxrc: `GetInternalFileName`: Call to `Printf`: Format string arg is now constant. (PR #24547)

19 views
Skip to first unread message

DoctorNoobingstoneIPresume

unread,
May 20, 2024, 7:10:37 PMMay 20
to wx-...@googlegroups.com, Subscribed

In the original code:

s.Printf(wxFileNameFromPath(parOutput) + wxT("$%03i-") + name2, i);

if wxFileNameFromPath(parOutput2) or name2 had contained '%' (format specifiers), the results would have been bad.

These strings are now given as additional arguments to Printf (corresponding to "%s" format specifiers),
and the format string argument itself is now constant.

This is a replacement of 9a5d32d as per #24437 (comment).


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/24547

Commit Summary

  • 2b8cba8 wxrc: `GetInternalFileName`: Call to `Printf`: Format string arg is now constant.

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24547@github.com>

VZ

unread,
May 23, 2024, 12:04:39 PMMay 23
to wx-...@googlegroups.com, Subscribed

Applying as well, thanks!


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24547/c2125960429@github.com>

VZ

unread,
May 23, 2024, 12:04:39 PMMay 23
to wx-...@googlegroups.com, Subscribed

Closed #24547 via a01c470.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24547/issue_event/12901781475@github.com>

DoctorNoobingstoneIPresume

unread,
May 29, 2024, 3:52:40 AMMay 29
to wx-...@googlegroups.com, Subscribed

You are most welcome, thank you for this and for all your work !! 🌈


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/24547/c2136771574@github.com>

Reply all
Reply to author
Forward
0 new messages