OSX iOS update app window layout methods (PR #25849)
Stefan Csomor
new iOS versions allow simpler code, also make sure that by default we stay in the ‚safe‘ area for the client area, outside of status bars etc.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/25849
Commit Summary
- 3cb7a33 remove interface oriented corrections
- 2c33aeb remove outdated code guards
- 73675cc unify usage
- b4c8386 iOS support clientAreaOrigin
File Changes
(5 files)
- M src/osx/iphone/nonownedwnd.mm (18)
- M src/osx/iphone/toolbar.mm (2)
- M src/osx/iphone/utils.mm (15)
- M src/osx/nonownedwnd_osx.cpp (7)
- M src/osx/toplevel_osx.cpp (8)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/25849.patch
- https://github.com/wxWidgets/wxWidgets/pull/25849.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25849)Tangentially related: unfortunately it looks like our macOS runner still doesn't pick up the jobs, see e.g. https://github.com/wxWidgets/wxWidgets/actions/runs/18166262593/job/51741370475 (I've restarted this one a few minutes ago).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
@csomor pushed 1 commit.
- db4c9b9 whitespace fix
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
csomor left a comment (wxWidgets/wxWidgets#25849)Tangentially related: unfortunately it looks like our macOS runner still doesn't pick up the jobs, see e.g. https://github.com/wxWidgets/wxWidgets/actions/runs/18166262593/job/51741370475 (I've restarted this one a few minutes ago).
it's a few hours later now, and all CMake jobs are green, except wxOSX Ninja and wxIOS, but these are not running on our own mac, or do I not see the obvious ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25849)it's a few hours later now, and all CMake jobs are green, except wxOSX Ninja and wxIOS, but these are not running on our own mac, or do I not see the obvious ?
Thanks, everything does look fine now, the other jobs just haven't been restarted, apparently. I've restarted one of them just now and it is running.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#25849)BTW, should I squash-merge this or will you do it yourself?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Stefan Csomor
Merged #25849 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.