#19264: wxComboBox needs EVT_TEXT that is defined in wx/textctrl.h

[wxTrac]

#19264: wxComboBox needs EVT_TEXT that is defined in wx/textctrl.h
-----------------------------------+--------------------
Reporter: ardovm | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: GUI-all | Version: 3.1.5
Keywords: wxComboBox wxTextCtrl | Blocked By:
Blocking: | Patch: 0
-----------------------------------+--------------------
After changeset:d3eafa4d1/git-wxWidgets file wx/combobox.h does not
include wx/textctrl.h any more.

In order to use the `EVT_TEXT` macro, one has to include `wx/textctrl.h`
explicitly.

Either this should be fixed, or the documentation shall be updated.

I can file a PR but I need to know what's the best way to solve this.

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19264>

[wxTrac]

#19264: wxComboBox needs EVT_TEXT that is defined in wx/textctrl.h

----------------------+-----------------------------------
Reporter: ardovm | Owner:
Type: defect | Status: confirmed

Priority: normal | Milestone:
Component: GUI-all | Version: 3.1.5

Resolution: | Keywords: wxComboBox wxTextCtrl

Blocked By: | Blocking:
Patch: 0 |

----------------------+-----------------------------------
Changes (by vadz):

* status: new => confirmed


Comment:

Oops, so while fixing one compatibility problem I've created another one.

Thanks for noticing it, I guess I'm just going to restore `wx/textctrl.h`
inclusion, it's a bit ugly, but it doesn't seem worth to be breaking the
existing code over it.

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19264#comment:1>

[wxTrac]

#19264: wxComboBox needs EVT_TEXT that is defined in wx/textctrl.h

----------------------+-------------------------------------
Reporter: ardovm | Owner: Vadim Zeitlin <vadim@…>
Type: defect | Status: closed

Priority: normal | Milestone:
Component: GUI-all | Version: 3.1.5

Resolution: fixed | Keywords: wxComboBox wxTextCtrl

Blocked By: | Blocking:
Patch: 0 |

----------------------+-------------------------------------
Changes (by Vadim Zeitlin <vadim@…>):

* owner: => Vadim Zeitlin <vadim@…>
* status: confirmed => closed
* resolution: => fixed


Comment:

In [changeset:"bd423096df59631b8423214ec76efe6f86af2308/git-wxWidgets"
bd423096d/git-wxWidgets]:
{{{
#!CommitTicketReference repository="git-wxWidgets"
revision="bd423096df59631b8423214ec76efe6f86af2308"
Restore recently removed #include wx/textctrl.h in wx/combobox.h

Some existing code relies on wxEVT_TEXT being defined after including
just wx/combobox.h too, so just keep this formally unnecessary but by
now impossible to remove #include removed in d3eafa4d18 (Fix compilation
of wxFormBuilder-generated code using wxTE_XXX, 2021-07-14).

See #14132.

Closes #19264.
}}}

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19264#comment:2>

[wxTrac]

#19264: wxComboBox needs EVT_TEXT that is defined in wx/textctrl.h

----------------------+-------------------------------------
Reporter: ardovm | Owner: Vadim Zeitlin <vadim@…>
Type: defect | Status: closed

Priority: normal | Milestone:
Component: GUI-all | Version: 3.1.5

Resolution: fixed | Keywords: wxComboBox wxTextCtrl

Blocked By: | Blocking:
Patch: 0 |

----------------------+-------------------------------------
Changes (by ardovm):

* cc: ardovm@… (added)


Comment:

Thank you!

--
Ticket URL: <https://trac.wxwidgets.org/ticket/19264#comment:3>