3.2 proposed backports (PR #23177)

40 views
Skip to first unread message

VZ

unread,
Jan 25, 2023, 8:39:09 AM1/25/23
to wx-...@googlegroups.com, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/23177

Commit Summary

  • 49c14fa Use margins around the text in wxGenericListCtrl on all platforms
  • 2bad14d Fix using pkg-config when cross-compiling to Linux targets
  • 05f67df Fix initializing wxFont from wxNativeFontInfo in wxQt
  • db838a6 Fix determining joystick product name

File Changes

(6 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177@github.com>

Maarten

unread,
Jan 26, 2023, 12:42:10 PM1/26/23
to wx-...@googlegroups.com, Subscribed

what about
4f6aa5a Merge branch 'print-preview-hidpi'
4517725 Fix typo in wxDEFINE_EVENT macro name in the documentation
8e60492 Fix wrongly recreating wxComboBox in disabled state in wxMSW
0ccf681 Avoid expanding the window size by too much on DPI change
94d738d Improve web view Edge error handling
1fef34d Fix web view Edge handler crash
70667fc Include wxrc.exe in the 64-bit wxMSW MSVC binary package


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/c1405366303@github.com>

VZ

unread,
Jan 26, 2023, 2:10:45 PM1/26/23
to wx-...@googlegroups.com, Subscribed

what about

Thanks, some of those have been already applied to 3.2:

4517725 Fix typo in wxDEFINE_EVENT macro name in the documentation

1d32868

70667fc Include wxrc.exe in the 64-bit wxMSW MSVC binary package

4cef952

8e60492 Fix wrongly recreating wxComboBox in disabled state in wxMSW

ac29c30

Others should be applied (they have/had the backport-3.2 label), but wanted to wait for a bit longer to see if any new problems are found before doing it, this includes

0ccf681 Avoid expanding the window size by too much on DPI change

4f6aa5a Merge branch 'print-preview-hidpi'

But maybe I should be more daring and apply them already...

Finally, I don't know if it's worth maintaining Edge backend in 3.2 or if it's not going to be able to follow the evolution of Edge itself there anyhow.

94d738d Improve web view Edge error handling
1fef34d Fix web view Edge handler crash

@TcT2k Should I backport them too?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/c1405476194@github.com>

VZ

unread,
Jan 26, 2023, 2:16:55 PM1/26/23
to wx-...@googlegroups.com, Push

@vadz pushed 3 commits.

  • a44c2a6 Fix determining joystick product name
  • e07d8cc Avoid expanding the window size by too much on DPI change
  • 2b10cee Fix size of native icons in MSW wxArtProvider in high DPI


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/push/12414328035@github.com>

VZ

unread,
Jan 26, 2023, 2:21:19 PM1/26/23
to wx-...@googlegroups.com, Push

@vadz pushed 3 commits.

  • e350ebb Fix determining joystick product name
  • f2b8938 Avoid expanding the window size by too much on DPI change
  • c1b27f3 Fix size of native icons in MSW wxArtProvider in high DPI


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/push/12414425252@github.com>

Tobias Taschner

unread,
Jan 26, 2023, 2:57:52 PM1/26/23
to wx-...@googlegroups.com, Subscribed

Finally, I don't know if it's worth maintaining Edge backend in 3.2 or if it's not going to be able to follow the evolution of Edge itself there anyhow.

94d738d Improve web view Edge error handling
1fef34d Fix web view Edge handler crash

@TcT2k Should I backport them too?

As the 3.2 doesn't include web handler support for edge these fixes wouldn't apply. Handler support in Edge is tied to the addition of wxWebViewHandler::StartRequest() and related classes, so backporting this would introduce quite a few changes to 3.2.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/c1405560673@github.com>

VZ

unread,
Jan 26, 2023, 4:58:19 PM1/26/23
to wx-...@googlegroups.com, Push

@vadz pushed 6 commits.

  • f16387b Fix support for high DPI icons in generic wxListCtrl
  • af2f7f2 Fix drawing wxTaskBarIcon under macOS in high DPI
  • 7163630 Fix wxUILocale compilation with musl
  • 42f3fb4 Use named links in Markdown instead of numbered ones
  • 0fd9546 Fix a possible crash in Mac menu item event handling
  • e2470b2 Allow selecting and copying text in wxMessageDialog on GTK


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/push/12415828035@github.com>

VZ

unread,
Jan 26, 2023, 4:59:50 PM1/26/23
to wx-...@googlegroups.com, Subscribed

I've backported all the other fixes marked as such in this branch now, with the exception of #23128 for which I'd like to get at least some testing in master first.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/c1405725350@github.com>

Lauri Nurmi

unread,
Jan 27, 2023, 7:29:55 AM1/27/23
to wx-...@googlegroups.com, Subscribed

Also what about:
bda8fc2 Prevent memory bloat when creating new wxThreads. (#22840)


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/c1406433412@github.com>

VZ

unread,
Jan 28, 2023, 7:49:44 PM1/28/23
to wx-...@googlegroups.com, Push

@vadz pushed 2 commits.

  • 54cecd5 Update bundled zlib to 1.2.13.1
  • ac625b1 Fix keyboard shortcuts handling in wxWebView under macOS


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/push/12433858729@github.com>

VZ

unread,
Jan 29, 2023, 2:37:34 PM1/29/23
to wx-...@googlegroups.com, Subscribed

Merged #23177 into 3.2.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/23177/issue_event/8382502131@github.com>

Reply all
Reply to author
Forward
0 new messages