cmake: missing check for curl (Issue #22648)

124 views
Skip to first unread message

Thomas Klausner

unread,
Jul 19, 2022, 6:06:56 AM7/19/22
to wx-...@googlegroups.com, Subscribed

When using the cmake build system, there is no check for curl, but later the build unconditionally tries to use curl/curl.h from include/wx/private/webrequest_curl.h and the build fails.

Platform and version information

  • wxWidgets version you use: 3.2.0
  • wxWidgets port you use: wxGTK
  • OS and its version: NetBSD 9.99.98/amd64
  • Compiler being used: gcc 10.3


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/22648@github.com>

VZ

unread,
Jul 31, 2022, 9:29:53 AM7/31/22
to wx-...@googlegroups.com, Subscribed

This is strange, we use find_package(CURL) which should fail if libcurl is really unavailable.

Perhaps we need to add some variable this call sets to the include (and library) options?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/22648/1200425923@github.com>

Maarten

unread,
Jul 31, 2022, 9:51:17 AM7/31/22
to wx-...@googlegroups.com, Subscribed

Indeed, if find_package(CURL) cannot find CURL, it disables wxUSE_WEBREQUEST_CURL and curl.h should never be included.

Can you check the result variables here (like message("CURL_INCLUDE_DIRS=${CURL_INCLUDE_DIRS}"))? And check if the found directories have a curl/curl.h?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/22648/1200429480@github.com>

Thomas Klausner

unread,
Jul 31, 2022, 12:56:57 PM7/31/22
to wx-...@googlegroups.com, Subscribed

Closed #22648 as completed.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issue/22648/issue_event/7096589854@github.com>

Thomas Klausner

unread,
Jul 31, 2022, 1:02:53 PM7/31/22
to wx-...@googlegroups.com, Subscribed

Sorry, this is a local problem.
The build framework I'm using tries to hide libraries that are not explicitly pulled in.
cmake finds the curl library anyway (pulled in indirectly via another dependency), but then the compiler wrapper is good enough to hide the header file and the build fails.
Nothing to do here, sorry for the noise!


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/issues/22648/1200461502@github.com>

Reply all
Reply to author
Forward
0 new messages