Add debug logging to `wxWebRequest` (PR #26086)
VZ
This is a draft as there is no documentation yet and I'd also like to log at least something (even though I don't think we can information at the same level of details as libcurl provides) for the WinHTTP backend.
I'd welcome comments about the API, notably I don't know if it really makes sense to allocate a new logger for each request, but if we want to reuse the same one, we probably need to pass the request to it?
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26086
Commit Summary
File Changes
(5 files)
- M include/wx/private/webrequest.h (9)
- M include/wx/webrequest.h (33)
- M src/common/webrequest.cpp (7)
- M src/common/webrequest_curl.cpp (92)
- M tests/net/webrequest.cpp (50)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26086.patch
- https://github.com/wxWidgets/wxWidgets/pull/26086.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26086)Thinking more about this, would it, perhaps, make more sense to enable debug logging at the session level? This is less flexible, but, in practice, I think I'm going to enable it for all requests anyhow when I need more information for troubleshooting.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 0a65254 Remove unused member variable in wxWebViewChromium code
- a8db111 Add wxWebRequestDebugLogger for details logging of HTTP transfers
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26086)I've moved setting the logger to the session as this seems more convenient and provided partial implementation for WinHTTP.
I plan to merge this if there are no objections, as this should be already useful when debugging any download-related problems.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.