Fix bug in wxGTK event loop implementation responsible for `wxWebRequestCURL` bugs (PR #27041)
VZ
Stop sending notifications to the handlers of an already deleted source.
This removes the need for the hack of 4e0fca8 (Fix crash when connection is refused in wxWebRequestCURL, 2024-10-27) which was needed to fix #24885 and also fixes the problem reported in #27040.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/27041
Commit Summary
- d42bc79 Don't notify already destroyed wxEventLoopSourceHandler in wxGTK
- 9175212 Revert hack in wxWebRequestCURL not needed any more
- b7117ec Add a unit test exercising now fixed bugs in wxWebRequestCURL
File Changes
(13 files)
- M build/cmake/tests/base/CMakeLists.txt (1)
- M build/cmake/tests/gui/CMakeLists.txt (7)
- M src/common/webrequest_curl.cpp (76)
- M src/gtk/evtloop.cpp (29)
- M tests/Makefile.in (8)
- M tests/makefile.gcc (8)
- M tests/makefile.vc (8)
- A tests/net/webrequest_local.cpp (270)
- M tests/test.bkl (6)
- M tests/test.vcxproj (1)
- M tests/test.vcxproj.filters (3)
- M tests/test_gui.vcxproj (1)
- M tests/test_gui.vcxproj.filters (3)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/27041.patch
- https://github.com/wxWidgets/wxWidgets/pull/27041.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
@vadz pushed 2 commits.
- 75b1f8a Add a unit test exercising now fixed bugs in wxWebRequestCURL
- 1b775d7 Fix passing wrong flags to wxEventLoopSourceHandler in wxQt
—
View it on GitHub or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#27041)@gunterkoenigsmann Please let me know if you can test this and check that this fixes the problem you were seeing.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.