Use current, not best, size for controls in wxGTK toolbars (PR #25949)

17 views
Skip to first unread message

VZ

unread,
Nov 2, 2025, 1:52:30 PM (8 days ago) Nov 2
to wx-...@googlegroups.com, Subscribed

The changes of 8f9f1a4 (Respect best control size when adding it to wxGTK wxToolBar, 2025-03-02) did in wxGTK what earlier b0ad9cc (Use control current, not best, size in wxMSW wxToolBar layout code, 2019-03-31) undid in wxMSW, so tweak them to work as in wxMSW and use the current control size if it's specified instead of the best size to make sure the control doesn't take too much space in the toolbar.

This makes appearance of the toolbar containing wxChoice in the toolbar sample much more reasonable.


Not sure if anybody has any comments about this, but it doesn't seem right to have very different behaviour in wxMSW and wxGTK and the (current) wxMSW one seems more reasonable.


You can view, comment on, or merge this pull request online at:

  https://github.com/wxWidgets/wxWidgets/pull/25949

Commit Summary

  • 8a69584 Use current, not best, size for controls in wxGTK toolbars

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25949@github.com>

VZ

unread,
Nov 8, 2025, 7:26:16 PM (2 days ago) Nov 8
to wx-...@googlegroups.com, Subscribed

Closed #25949.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25949/issue_event/20814792740@github.com>

VZ

unread,
Nov 8, 2025, 7:26:19 PM (2 days ago) Nov 8
to wx-...@googlegroups.com, Subscribed
vadz left a comment (wxWidgets/wxWidgets#25949)

Applied in the commit above.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <wxWidgets/wxWidgets/pull/25949/c3507235490@github.com>

Reply all
Reply to author
Forward
0 new messages