Nullify WebView (Edge) implemenation pointer, add pointer check (PR #26563)
Blake-Madden
Null out m_impl in case there are any stray pending events.
Also, check that pointer in size event handler.
Also, minor comment fixes.
You can view, comment on, or merge this pull request online at:
https://github.com/wxWidgets/wxWidgets/pull/26563
Commit Summary
File Changes
(1 file)
- M src/msw/webview_edge.cpp (14)
Patch Links:
- https://github.com/wxWidgets/wxWidgets/pull/26563.patch
- https://github.com/wxWidgets/wxWidgets/pull/26563.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
VZ
vadz left a comment (wxWidgets/wxWidgets#26563)Sorry, this doesn't look like the correct fix: just calling OnSize() on an already destroyed instance of wxWebViewEdge is already undefined behaviour, so we must prevent this from happening. Probably the correct fix is to call Unbind(wxEVT_SIZE) in dtor.
Also, if you really need to change comments (I'd rather leave them be), please do it in a separate commit and not in the same one making some non-trivial changes. TIA!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.